Remove support for legacy reports endpoint #2319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add hasFinalizedReports to persistence * Add hasReportsToSend to SessionReportingCoordinator * Rely on SessionReportingCoordinator for hasReports check
* Get sorted open session IDs from persistence * Plumb sorted open session IDs through SessionReportingCoordinator
* Remove proto file handling from CrashlyticsController * Pass session reporting coordinator into CrashlyticsController
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (9ae4274d) is created by Prow via merging commits: 1faa4e2 d0555ad. |
|
@mrwillis21: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (9ae4274d) is created by Prow via merging commits: 1faa4e2 d0555ad. |
mrichards
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
@mrwillis21 & I have manually tested all P0 & P1 test cases across a variety of API levels and found no regressions, so my review pass was largely for style / clarity. LGTM, nice work Matt!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy reporting endpoint has been retired, this removes support for it from the SDK.