Skip to content

i18n #4507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2023
Merged

i18n #4507

merged 4 commits into from
Jan 5, 2023

Conversation

kaibolay
Copy link
Contributor

@kaibolay kaibolay commented Jan 3, 2023

Translations from n41155-77g2sqbts51e8.zip - retrieved from Nalu

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@kaibolay kaibolay requested a review from lfkellogg January 3, 2023 20:43
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 3, 2023

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (e61f367) to 77.14% (4cfb4de) by ?.

    44 individual files with coverage change

    FilenameBase (e61f367)Merge (4cfb4de)Diff
    AabUpdater.java?98.67%?
    ApkInstaller.java?100.00%?
    ApkUpdater.java?93.07%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?84.62%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?1.12%?
    FeedbackSender.java?84.62%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.89%?
    FirebaseAppDistributionLifecycleNotifier.java?92.91%?
    FirebaseAppDistributionNotificationsManager.java?87.18%?
    FirebaseAppDistributionRegistrar.java?86.27%?
    FirebaseAppDistributionTesterApiClient.java?88.54%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.67%?
    LogWrapper.java?100.00%?
    NewReleaseFetcher.java?85.11%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?85.54%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?41.18%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?100.00%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TaskCache.java?100.00%?
    TaskCompletionSourceCache.java?68.97%?
    TaskUtils.java?92.50%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?90.18%?
    TesterSignInManager.java?96.12%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskCache.java?91.30%?
    UpdateTaskImpl.java?76.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/P7dHZGwkY0.html

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Unit Test Results

166 tests   166 ✔️  38s ⏱️
  16 suites      0 💤
  16 files        0

Results for commit 7fbe95d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@lfkellogg lfkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be kind of a pain but I feel like we should at least try to load each of these locally at least once. Not every string but at least an example from every language. Do you want to divide and conquer?

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 3, 2023

Size Report 1

Affected Products

  • base

    TypeBase (e61f367)Merge (4cfb4de)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-annotations

    TypeBase (e61f367)Merge (4cfb4de)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?9.46 kB? (?)
  • firebase-appdistribution

    TypeBase (e61f367)Merge (4cfb4de)Diff
    aar?194 kB? (?)
    apk (aggressive)?873 kB? (?)
    apk (release)?2.05 MB? (?)
  • firebase-appdistribution-api

    TypeBase (e61f367)Merge (4cfb4de)Diff
    aar?16.0 kB? (?)
    apk (aggressive)?95.8 kB? (?)
    apk (release)?706 kB? (?)
  • firebase-common

    TypeBase (e61f367)Merge (4cfb4de)Diff
    aar?67.4 kB? (?)
    apk (aggressive)?95.1 kB? (?)
    apk (release)?700 kB? (?)
  • firebase-components

    TypeBase (e61f367)Merge (4cfb4de)Diff
    aar?44.9 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?33.6 kB? (?)
  • firebase-installations

    TypeBase (e61f367)Merge (4cfb4de)Diff
    aar?55.0 kB? (?)
    apk (aggressive)?96.6 kB? (?)
    apk (release)?724 kB? (?)
  • firebase-installations-interop

    TypeBase (e61f367)Merge (4cfb4de)Diff
    aar?8.05 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Lbx7IYNvBI.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 3, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (4cfb4de) and the base commit (e61f367) are not available.

No macrobenchmark data found for the base commit (e61f367). Analysis for the CI merge commit (4cfb4de) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BaKTuwW8oB/index.html

@kaibolay
Copy link
Contributor Author

kaibolay commented Jan 4, 2023

/retest

@kaibolay kaibolay merged commit ece0ab9 into fad/in-app-feedback Jan 5, 2023
@kaibolay kaibolay deleted the kb/i18n branch January 5, 2023 15:18
lfkellogg pushed a commit that referenced this pull request Jan 5, 2023
* Translations from n41155-77g2sqbts51e8.zip - retrieved from https://partnerdash.google.com/nalu?utm_source=olp#p=translationprojectpage&selectedTab=0&shortId=n41155
* Move copyright to separate line and update from 2021 to 2022.
* The product name "Firebase App-Distribution" should not be translated - at least not to German.
* Change escaping of apostrophes from `'` to `\'`.
kaibolay added a commit that referenced this pull request Jan 23, 2023
* Translations from n41155-77g2sqbts51e8.zip - retrieved from https://partnerdash.google.com/nalu?utm_source=olp#p=translationprojectpage&selectedTab=0&shortId=n41155
* Move copyright to separate line and update from 2021 to 2022.
* The product name "Firebase App-Distribution" should not be translated - at least not to German.
* Change escaping of apostrophes from `'` to `\'`.
lfkellogg pushed a commit that referenced this pull request Jan 25, 2023
* Translations from n41155-77g2sqbts51e8.zip - retrieved from https://partnerdash.google.com/nalu?utm_source=olp#p=translationprojectpage&selectedTab=0&shortId=n41155
* Move copyright to separate line and update from 2021 to 2022.
* The product name "Firebase App-Distribution" should not be translated - at least not to German.
* Change escaping of apostrophes from `'` to `\'`.
lfkellogg pushed a commit that referenced this pull request Jan 25, 2023
* Translations from n41155-77g2sqbts51e8.zip - retrieved from https://partnerdash.google.com/nalu?utm_source=olp#p=translationprojectpage&selectedTab=0&shortId=n41155
* Move copyright to separate line and update from 2021 to 2022.
* The product name "Firebase App-Distribution" should not be translated - at least not to German.
* Change escaping of apostrophes from `'` to `\'`.
@firebase firebase locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants