Skip to content

Pass a CoroutineContext, not CoroutineDispatcher, to SessionCoordinator #4950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2023
Merged

Pass a CoroutineContext, not CoroutineDispatcher, to SessionCoordinator #4950

merged 1 commit into from
Apr 28, 2023
+9 −7

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Apr 27, 2023

No description provided.

@mrober mrober requested review from samedson and visumickey April 27, 2023 19:54
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (c63bc13) to 72.14% (13eae6b) by ?.

    16 individual files with coverage change

    FilenameBase (c63bc13)Merge (13eae6b)Diff
    ApplicationInfo.kt?100.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsEarly.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    LocalOverrideSettings.kt?88.46%?
    RemoteSettings.kt?78.57%?
    SessionCoordinator.kt?76.47%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?100.00%?
    SessionGenerator.kt?20.00%?
    SessionInitiator.kt?66.67%?
    SessionsSettings.kt?83.33%?
    SettingsCache.kt?94.12%?
    SettingsProvider.kt?0.00%?
    Time.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1jEIIOdar7.html

@github-actions
Copy link
Contributor

Unit Test Results

20 files  20 suites   24s ⏱️
29 tests 29 ✔️ 0 💤 0 ❌
58 runs  58 ✔️ 0 💤 0 ❌

Results for commit d14c057.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (c63bc13)Merge (13eae6b)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-datatransport

    TypeBase (c63bc13)Merge (13eae6b)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)

  • firebase-sessions

    TypeBase (c63bc13)Merge (13eae6b)Diff
    aar?76.2 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JSXYGrrOn1.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (13eae6b) and the base commit (c63bc13) are not available.

No macrobenchmark data found for the base commit (c63bc13). Analysis for the CI merge commit (13eae6b) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VER1Z72HsT/index.html

@mrober mrober merged commit d4a30e1 into firebase-sessions Apr 28, 2023
@mrober mrober deleted the sessions-context branch April 28, 2023 14:13
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@visumickey visumickey visumickey approved these changes

@samedson samedson Awaiting requested review from samedson

Assignees
No one assigned
Labels
no-changelog size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrober @google-oss-bot @visumickey