Populate GMPID header #2670
Merged
Populate GMPID header #2670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/gmpid
branch
2 times, most recently
from
06d45e3 to
dcc7cf4
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/gmpid
branch
from
dcc7cf4 to
8f704d0
Compare
fredzqm
approved these changes
Feb 25, 2020
b/147740859 |
|
Adding @Feiyang1 for codeowners. |
Feiyang1
reviewed
Feb 26, 2020
|
The backend already accepts this header (for Storage only). |
Feiyang1
approved these changes
Feb 26, 2020
schmidt-sebastian
added a commit
that referenced
this pull request
Feb 28, 2020
This reverts commit 7d5a29f.
schmidt-sebastian
added a commit
that referenced
this pull request
Feb 28, 2020
schmidt-sebastian
added a commit
that referenced
this pull request
Feb 28, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This populates the GMPID header for Storage on Web.
See https://github.com/firebase/firebase-android-sdk/blob/e95f91e64c79206549302e9f37341534c29f58af/firebase-storage/src/main/java/com/google/firebase/storage/network/NetworkRequest.java#L53 for reference.