Skip to content

Revert "Populate GMPID header" #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2020
Merged

Revert "Populate GMPID header" #2696

merged 1 commit into from
Feb 28, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

Reverts #2670

We need to whitelist x-firebase-gmpid in the CORS preflight request.

Fixes #2695

@schmidt-sebastian schmidt-sebastian merged commit 3679e87 into master Feb 28, 2020
schmidt-sebastian added a commit that referenced this pull request Feb 28, 2020
@schmidt-sebastian
Revert "Revert "Populate GMPID header (#2670)" (#2696)"
451ad4c 
This reverts commit 3679e87.
@schmidt-sebastian schmidt-sebastian mentioned this pull request Mar 10, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Mar 30, 2020
@schmidt-sebastian schmidt-sebastian deleted the revert-2670-mrschmidt/gmpid branch April 6, 2020 19:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

Assignees

@Feiyang1 Feiyang1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v7.9.2 seems to introduce CORS issue with Firebase Storage
2 participants
@schmidt-sebastian @Feiyang1