Skip to content

Populate GMPID header #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Mar 10, 2020

This is the exact same as #2670, that was reverted in #2696 since it broke CORS preflight requests.

We have since whitelisted the new header in CORS:

> Request URL: https://firebasestorage.googleapis.com/v0/b/***/o***
> Request Method: OPTIONS
< access-control-allow-headers: authorization,x-firebase-gmpid,x-firebase-storage-version,x-goog-upload-command,x-goog-upload-offset

> Request URL: https://firebasestorage.googleapis.com/v0/b/***/o***
> Request Method: POST
> x-firebase-gmpid: 1:***:web:***
< Status Code: 200 

@schmidt-sebastian
Copy link
Contributor Author

@jsdt confirmed that the backend is fully rolled out.

@schmidt-sebastian schmidt-sebastian merged commit aa04416 into master Mar 12, 2020
@schmidt-sebastian schmidt-sebastian deleted the revert-2696-revert-2670-mrschmidt/gmpid branch April 6, 2020 19:26
@firebase firebase locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants