Add an ObjectValue builder #2671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
schmidt-sebastian
force-pushed
the
mrschmidt/rewritefieldvalue-1
branch
from
ed58e2e to
6944854
Compare
schmidt-sebastian
requested review from
var-const
and removed request for
hiranya911,
Feiyang1 and
hsubox76
var-const
approved these changes
Feb 25, 2020
| expect(objValue.value()).to.deep.equal(expected); | ||
| expect(objValue2.value()).to.deep.equal(expected); | ||
| expect(objValue3.value()).to.deep.equal(expected); | ||
| expect(objValue4.value()).to.deep.equal(expected); | ||
| }); | ||
|
|
||
| it('can delete multiple fields', () => { |
There was a problem hiding this comment.
Optional: add a test showing it's possible to set and immediately delete fields? (e.g., set a, b, c, delete b, check that the end result only has a, c)
There was a problem hiding this comment.
Added a test.
It's #1150. I updated the description. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of firebase/firebase-android-sdk#1150
Many more PRs to come. See firebase/firebase-android-sdk#1217 for reference.