-
Notifications
You must be signed in to change notification settings - Fork 624
Remove internal FieldValue representation #1217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Continue to review full report at Codecov.
|
* Make ServerTimestampValue methods static
aa03b1b
to
4864c6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This merges the feature branch for the FieldValue removal into master. All PRs have been reviewed individually. There are no remaining TODOs from any of the PRs.
Jetpack Benchmark results (A getData() call on every document in a 1000 document QuerySnapshot): -59% runtime versus 21.4
AAR Size reduction: 10.3 Kb (-1%) (WHEEE!)
LOC reduction (excluding generated code, comments, tests): -148 lines (-1.3%) (WHEEE!)
There are no functional changes in this PR, but all Query canonical IDs change and are rewritten.