Skip to content

Remove internal FieldValue representation #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 7, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Feb 7, 2020

This merges the feature branch for the FieldValue removal into master. All PRs have been reviewed individually. There are no remaining TODOs from any of the PRs.

Jetpack Benchmark results (A getData() call on every document in a 1000 document QuerySnapshot): -59% runtime versus 21.4
AAR Size reduction: 10.3 Kb (-1%) (WHEEE!)
LOC reduction (excluding generated code, comments, tests): -148 lines (-1.3%) (WHEEE!)

There are no functional changes in this PR, but all Query canonical IDs change and are rewritten.

@googlebot googlebot added the cla: yes Override cla label Feb 7, 2020
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d1a75a9). Click here to learn what that means.
The diff coverage is 76.9%.

Flag Coverage Δ Complexity Δ
#Encoders_FirebaseEncodersJson 100% <ø> (?) 0 <ø> (?)
#Encoders_FirebaseEncodersProcessor 100% <ø> (?) 0 <ø> (?)
#Encoders_FirebaseEncodersReflective 100% <ø> (?) 0 <ø> (?)
#FirebaseAbt 100% <ø> (?) 0 <ø> (?)
#FirebaseCommon 100% <ø> (?) 0 <ø> (?)
#FirebaseCommon_DataCollectionTests 100% <ø> (?) 0 <ø> (?)
#FirebaseCommon_Ktx 100% <ø> (?) 0 <ø> (?)
#FirebaseComponents 100% <ø> (?) 0 <ø> (?)
#FirebaseConfig 100% <ø> (?) 0 <ø> (?)
#FirebaseConfig_Ktx 100% <ø> (?) 0 <ø> (?)
#FirebaseCrashlytics 100% <ø> (?) 0 <ø> (?)
#FirebaseDatabase 100% <ø> (?) 0 <ø> (?)
#FirebaseDatabaseCollection 100% <ø> (?) 0 <ø> (?)
#FirebaseDatabase_Ktx 100% <ø> (?) 0 <ø> (?)
#FirebaseDatatransport 100% <ø> (?) 0 <ø> (?)
#FirebaseDynamicLinks 100% <ø> (?) 0 <ø> (?)
#FirebaseDynamicLinks_Ktx 100% <ø> (?) 0 <ø> (?)
#FirebaseFirestore 61.85% <76.9%> (?) 2224 <117> (?)
#FirebaseFirestore_Ktx 41.17% <ø> (?) 0 <ø> (?)
#FirebaseFunctions 100% <ø> (?) 0 <ø> (?)
#FirebaseFunctions_Ktx 100% <ø> (?) 0 <ø> (?)
#FirebaseInappmessaging 100% <ø> (?) 0 <ø> (?)
#FirebaseInappmessagingDisplay 100% <ø> (?) 0 <ø> (?)
#FirebaseInappmessagingDisplay_Ktx 100% <ø> (?) 0 <ø> (?)
#FirebaseInappmessaging_Ktx 100% <ø> (?) 0 <ø> (?)
#FirebaseInstallations 100% <ø> (?) 0 <ø> (?)
#FirebaseSegmentation 100% <ø> (?) 0 <ø> (?)
#FirebaseStorage 100% <ø> (?) 0 <ø> (?)
#FirebaseStorage_Ktx 100% <ø> (?) 0 <ø> (?)
#Tools_Errorprone 100% <ø> (?) 0 <ø> (?)
#Tools_Lint 100% <ø> (?) 0 <ø> (?)
#Transport_TransportBackendCct 100% <ø> (?) 0 <ø> (?)
#Transport_TransportRuntime 100% <ø> (?) 0 <ø> (?)
Impacted Files Coverage Δ Complexity Δ
...firebase/firestore/model/mutation/SetMutation.java 64% <ø> (ø) 8 <0> (?)
...le/firebase/firestore/model/mutation/Mutation.java 87.5% <ø> (ø) 9 <0> (?)
...ebase/firestore/model/mutation/DeleteMutation.java 68.42% <ø> (ø) 7 <0> (?)
...a/com/google/firebase/firestore/core/UserData.java 49.51% <ø> (ø) 0 <0> (?)
...irebase/firestore/local/SQLiteCollectionIndex.java 42.85% <ø> (ø) 1 <0> (?)
...com/google/firebase/firestore/core/IndexRange.java 83.33% <ø> (ø) 3 <0> (?)
...om/google/firebase/firestore/local/LocalStore.java 95.23% <ø> (ø) 67 <0> (?)
.../com/google/firebase/firestore/model/Document.java 85.71% <ø> (ø) 19 <0> (?)
...ebase/firestore/model/mutation/VerifyMutation.java 30.76% <ø> (ø) 2 <0> (?)
...main/java/com/google/firebase/firestore/Query.java 2.93% <0%> (ø) 4 <0> (?)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a75a9...fdf249d. Read the comment docs.

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/rewritefieldvalue branch from aa03b1b to 4864c6a Compare February 7, 2020 20:54
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Feb 7, 2020
@wilhuff wilhuff merged commit fdf249d into master Feb 7, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/rewritefieldvalue branch February 8, 2020 01:32
@firebase firebase locked and limited conversation to collaborators Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants