-
Notifications
You must be signed in to change notification settings - Fork 946
Add new build rule for gendeps script #3440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
846b768
to
92038ca
Compare
💥 No ChangesetLatest commit: f7c4bcb Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
92038ca
to
0172925
Compare
💥 No ChangesetLatest commit: 0172925 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
0172925
to
5a467b9
Compare
719ba92
to
13a2c89
Compare
13a2c89
to
20625e5
Compare
Binary Size ReportAffected SDKs
Test Logs
|
Hm, I need to look at the size increase. Very strange. |
Fixed |
Instead of checking in js files, can you use You can create a |
These scripts are used in transformers, as such I don't think we can use |
This is required since the Node build now uses UMD and the Browser builds are mangled. As such, we no longer have a nice build to look at to generate the list of dependencies.
Unfortunately, using the
rollup.shared.js
file in the new script meant that I had to convert it into CommonJS.I also checked in the script/*.js file and removed the prebuilt step (for development speed). Furthermore, I removed the
verify-depedencies.test.ts
tests since I only ever looked at the JSON files itself (these tests are pretty slow).