Skip to content

Add Browser tests for Lite and Exp #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 23, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2020

💥 No Changeset

Latest commit: 24389cd

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -1,50 +0,0 @@
/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is #3440. I cannot include this test since it uses path

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 22, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (e117354) Head (3b48629) Diff
    browser 245 kB 245 kB +20 B (+0.0%)
    esm2017 193 kB 193 kB +20 B (+0.0%)
    module 243 kB 243 kB +20 B (+0.0%)
    react-native 193 kB 193 kB +20 B (+0.0%)
  • @firebase/firestore/exp

    Type Base (e117354) Head (3b48629) Diff
    browser 187 kB 187 kB -33 B (-0.0%)
    main 511 kB 511 kB -50 B (-0.0%)
    react-native 188 kB 187 kB -33 B (-0.0%)
  • @firebase/firestore/lite

    Type Base (e117354) Head (3b48629) Diff
    browser 68.0 kB 68.0 kB -33 B (-0.0%)
    main 497 kB 497 kB -44 B (-0.0%)
    react-native 68.1 kB 68.1 kB -33 B (-0.0%)
  • @firebase/firestore/memory

    Type Base (e117354) Head (3b48629) Diff
    browser 184 kB 184 kB +20 B (+0.0%)
    esm2017 145 kB 145 kB +20 B (+0.0%)
    module 182 kB 182 kB +20 B (+0.0%)
    react-native 145 kB 145 kB +20 B (+0.0%)
  • firebase

    Type Base (e117354) Head (3b48629) Diff
    firebase-firestore.js 283 kB 283 kB +20 B (+0.0%)
    firebase-firestore.memory.js 224 kB 224 kB +20 B (+0.0%)
    firebase.js 817 kB 817 kB +20 B (+0.0%)

Test Logs

@Feiyang1 Feiyang1 removed their assignment Jul 23, 2020
@schmidt-sebastian schmidt-sebastian changed the base branch from mrschmidt/fixlitetests to master July 23, 2020 17:45
@schmidt-sebastian schmidt-sebastian merged commit 18e5dea into master Jul 23, 2020
@firebase firebase locked and limited conversation to collaborators Aug 23, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/browsertests branch November 9, 2020 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants