meta(changelog): Update changelog for 8.0.0-beta.4 #11770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ports `packages/browser/test/integration/suites/loader.js` and `packages/browser/test/integration/suites/loader-specific.js` to playwright. Specifically it just adds tests for SDK source and breadcrumbs, which were missing previously. ref #11084
…0.37.0 (#11694) Bumps [@opentelemetry/instrumentation-mysql](https://github.com/open-telemetry/opentelemetry-js-contrib) from 0.35.0 to 0.37.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/open-telemetry/opentelemetry-js-contrib/releases"><code>@opentelemetry/instrumentation-mysql</code>'s releases</a>.</em></p> <blockquote> <h2>instrumentation-user-interaction: v0.37.0</h2> <h2><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/instrumentation-user-interaction-v0.36.0...instrumentation-user-interaction-v0.37.0">0.37.0</a> (2024-04-03)</h2> <h3>Features</h3> <ul> <li><strong>deps:</strong> update otel-js to 1.23.0/0.50.0 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/2076">#2076</a>) (<a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/d5f079b3992395dcfb3b791c9fdaeefd6d6526f8">d5f079b</a>)</li> </ul> <h2>instrumentation-long-task: v0.37.0</h2> <h2><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/instrumentation-long-task-v0.36.0...instrumentation-long-task-v0.37.0">0.37.0</a> (2024-04-03)</h2> <h3>Features</h3> <ul> <li><strong>deps:</strong> update otel-js to 1.23.0/0.50.0 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/2076">#2076</a>) (<a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/d5f079b3992395dcfb3b791c9fdaeefd6d6526f8">d5f079b</a>)</li> </ul> <h2>instrumentation-document-load: v0.37.0</h2> <h2><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/instrumentation-document-load-v0.36.0...instrumentation-document-load-v0.37.0">0.37.0</a> (2024-04-03)</h2> <h3>Features</h3> <ul> <li><strong>deps:</strong> update otel-js to 1.23.0/0.50.0 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/2076">#2076</a>) (<a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/d5f079b3992395dcfb3b791c9fdaeefd6d6526f8">d5f079b</a>)</li> </ul> <h2>instrumentation-winston: v0.36.0</h2> <h2><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/instrumentation-winston-v0.35.0...instrumentation-winston-v0.36.0">0.36.0</a> (2024-04-03)</h2> <h3>Features</h3> <ul> <li><strong>deps:</strong> update otel-js to 1.23.0/0.50.0 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/2076">#2076</a>) (<a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/d5f079b3992395dcfb3b791c9fdaeefd6d6526f8">d5f079b</a>)</li> <li><strong>instrumentation-winston:</strong> add log sending to Logs API (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1837">#1837</a>) (<a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/358345f1384635ae2cb072082b25907dcbcaebcb">358345f</a>)</li> </ul> <h3>Dependencies</h3> <ul> <li>The following workspace dependencies were updated <ul> <li>devDependencies <ul> <li><code>@opentelemetry/winston-transport</code> bumped from ^0.1.0 to ^0.2.0</li> </ul> </li> </ul> </li> </ul> <h2>instrumentation-router: v0.36.0</h2> <h2><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/instrumentation-router-v0.35.0...instrumentation-router-v0.36.0">0.36.0</a> (2024-04-03)</h2> <h3>Features</h3> <ul> <li><strong>deps:</strong> update otel-js to 1.23.0/0.50.0 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/2076">#2076</a>) (<a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/d5f079b3992395dcfb3b791c9fdaeefd6d6526f8">d5f079b</a>)</li> </ul> <h2>instrumentation-restify: v0.37.0</h2> <h2><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/instrumentation-restify-v0.36.0...instrumentation-restify-v0.37.0">0.37.0</a> (2024-04-03)</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/fcea8ca0c83cb1dcd8ac736e5ea4d22ff20dc982"><code>fcea8ca</code></a> chore: release main (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1935">#1935</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/d2f59e92c186e408a04be329695d41b262ab7ade"><code>d2f59e9</code></a> chore(instr-runtime-node): update some deps to same versions as other contrib...</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/710631309e2af7c063f0dfcf489f3197b87c9987"><code>7106313</code></a> test(instr-express): add test for ESM (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1966">#1966</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/43fd4eb61630abf58b6647efc0d68e7781a0b096"><code>43fd4eb</code></a> updated zone.js version (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1934">#1934</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/edc426b348bc5f45ff6816bcd5ea7473251a05df"><code>edc426b</code></a> chore(deps): update deps matching "@opentelemetry/*" (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1978">#1978</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/fef1b3677bf6d0ecab371903136bfa726e01c1ad"><code>fef1b36</code></a> fix(instrumentaiton-runtime-node)!: rename exported instrumentation to match ...</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/2e9fce4d15bc15fd3cb0e98ad36af6f7d4cc3c38"><code>2e9fce4</code></a> Add <code>@opentelemetry/api</code> as peerDependencies in <code>@opentelemetry/resource-detecto</code>...</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/c00f529f65f703c5fe1e740e70f4f442dd671b1b"><code>c00f529</code></a> refactor(instrumentation-perf-hooks): rename to instrumentation-runtime-node ...</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/e11f86e59427bd86f539fc9ba7dcd23873860f9a"><code>e11f86e</code></a> docs(instrumentation-graphql): gql supported versions (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1969">#1969</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/83624b1c30408654306fbfacbdf86aee1a93c097"><code>83624b1</code></a> test(instrumentation-mysql): add missing -p to ts-mocha (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1968">#1968</a>)</li> <li>Additional commits viewable in <a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/host-metrics-v0.35.0...contrib-test-utils-v0.37.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[Gitflow] Merge master into develop
…o 0.35.0 (#11690) Bumps [@opentelemetry/instrumentation-fastify](https://github.com/open-telemetry/opentelemetry-js-contrib) from 0.33.0 to 0.35.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/open-telemetry/opentelemetry-js-contrib/releases"><code>@opentelemetry/instrumentation-fastify</code>'s releases</a>.</em></p> <blockquote> <h2>instrumentation-net: v0.35.0</h2> <h2><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/instrumentation-net-v0.34.0...instrumentation-net-v0.35.0">0.35.0</a> (2024-04-03)</h2> <h3>Features</h3> <ul> <li><strong>deps:</strong> update otel-js to 1.23.0/0.50.0 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/2076">#2076</a>) (<a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/d5f079b3992395dcfb3b791c9fdaeefd6d6526f8">d5f079b</a>)</li> </ul> <h2>instrumentation-memcached: v0.35.0</h2> <h2><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/instrumentation-memcached-v0.34.0...instrumentation-memcached-v0.35.0">0.35.0</a> (2024-04-03)</h2> <h3>Features</h3> <ul> <li><strong>deps:</strong> update otel-js to 1.23.0/0.50.0 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/2076">#2076</a>) (<a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/d5f079b3992395dcfb3b791c9fdaeefd6d6526f8">d5f079b</a>)</li> </ul> <h3>Dependencies</h3> <ul> <li>The following workspace dependencies were updated <ul> <li>devDependencies <ul> <li><code>@opentelemetry/contrib-test-utils</code> bumped from ^0.37.0 to ^0.38.0</li> </ul> </li> </ul> </li> </ul> <h2>instrumentation-knex: v0.35.0</h2> <h2><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/instrumentation-knex-v0.34.0...instrumentation-knex-v0.35.0">0.35.0</a> (2024-04-03)</h2> <h3>Features</h3> <ul> <li><strong>deps:</strong> update otel-js to 1.23.0/0.50.0 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/2076">#2076</a>) (<a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/d5f079b3992395dcfb3b791c9fdaeefd6d6526f8">d5f079b</a>)</li> </ul> <h2>instrumentation-generic-pool: v0.35.0</h2> <h2><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/instrumentation-generic-pool-v0.34.0...instrumentation-generic-pool-v0.35.0">0.35.0</a> (2024-04-03)</h2> <h3>Features</h3> <ul> <li><strong>deps:</strong> update otel-js to 1.23.0/0.50.0 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/2076">#2076</a>) (<a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/d5f079b3992395dcfb3b791c9fdaeefd6d6526f8">d5f079b</a>)</li> </ul> <h2>instrumentation-fastify: v0.35.0</h2> <h2><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/instrumentation-fastify-v0.34.0...instrumentation-fastify-v0.35.0">0.35.0</a> (2024-04-03)</h2> <h3>Features</h3> <ul> <li><strong>deps:</strong> update otel-js to 1.23.0/0.50.0 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/2076">#2076</a>) (<a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/d5f079b3992395dcfb3b791c9fdaeefd6d6526f8">d5f079b</a>)</li> </ul> <h3>Dependencies</h3> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/32204a362d9dffd4cd69a1300e1f7d245df9df52"><code>32204a3</code></a> chore: release main (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1890">#1890</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/96244869d0fe22e6006fa6ef5e54839e06afb99d"><code>9624486</code></a> chore(deps): update otel-js to 1.21.0/0.48.0 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1914">#1914</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/12834d511d56bd92753b99f52a1e8e4391d9c78b"><code>12834d5</code></a> fix(example-fastify): update example to use latest versions (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1899">#1899</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/fce7d3b5e478ff7525c9ffe99e59bf35f8c06207"><code>fce7d3b</code></a> fix(instrumentation-redis-4): fix multi.exec() instrumentation for redis >=4....</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/f65f2f1482f6f9ca80681f09249dc2b75ef7e3db"><code>f65f2f1</code></a> fix: span emit warnings on express instrumentation (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1891">#1891</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/3156c94625024390ed63fa2e2fdd8b2895e14801"><code>3156c94</code></a> chore: Update deprecations in instrumentation-express/examples (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1842">#1842</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/c8bebc789f2e8ccb34b1230e00f8cef578aa600c"><code>c8bebc7</code></a> chore(renovate): use full list of experimental packages (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1897">#1897</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/c365375ce2d35c01df06c96a4faf8d5a5d9d1ec3"><code>c365375</code></a> feat(instrumentation-graphql): add option to ignore resolver spans (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js-contrib/issues/1858">#1858</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/c54e9b61a031469110d845387ae1853b9197063d"><code>c54e9b6</code></a> fix(mongodb-example): Ensure instrumentation is setup before mongoDB client i...</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js-contrib/commit/577a291cd527606b331d6732ba0eccc75422a0fc"><code>577a291</code></a> fix(instrumentation-aws-sdk): make empty context when SQS message has no prop...</li> <li>Additional commits viewable in <a href="https://github.com/open-telemetry/opentelemetry-js-contrib/compare/host-metrics-v0.33.0...host-metrics-v0.35.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This is a step to support INP on v8. It tries to forward port some stuff that has been merged into v7. It is a bit tricky to do this properly as this was spread over multiple PRs and cannot be directly ported at once. Closes #10945 --------- Co-authored-by: s1gr1d <[email protected]> Co-authored-by: Sigrid Huemer <[email protected]>
…ndency from Next.js package (#11717)
Adds ESM support to `@sentry/aws-serverless` and adds relevant OpenTelemetry integrations.
We do not want to allow users to capture super large canvases, enforce a max size limit Requires getsentry/rrweb#174 Closes #10498
As noticed by @ryan953 here: #11621 (comment), this was not actually working properly in NPM-mode. I added a proper test for this and fixed this, so hopefully should be all good now.
"...which is a dependency of the SvelteKit SDK" could also be understood as "you need this as additional dependency"
Let's see if that works now 🤞
Today, we have different behavior for the `trace` context in core/browser & node: In Node, we made the change so that `contexts.trace` only contains `span_id`, `trace_id` and `parent_span_id` for non-transaction events. In contrast, in core/browser we are always adding the full span trace context, if there is an active span (including e.g. data, status, etc.) This PR aligns this to use the node behavior everywhere. Transaction events are unchanged by this PR.
This was brought up in discord - we forgot to add `onlyIfParent` to the ui spans we emit for ember, so it's possible to capture a bunch of them as transactions, accidentally.
Pulls in a bunch of commits from rrweb upstream to address some outstanding perf issues
The primary change is to make `finalStartSpanOptions.name !== finalStartSpanOptions.name` -> `startSpanOptions.name !== finalStartSpanOptions.name` in `packages/browser/src/tracing/browserTracingIntegration.ts`. While I was here though I cleaned up some other code to improve bundle size. Let me know if you want me to extract the cleanup changes, I figured it's all easier to review here with the same context.
#11721) update the `addOpenTelemetryInstrumentation` API to use rest args.
This ports `packages/browser/test/integration/suites/builtins.js` to playwright. It also re-organizes the `eventListener` test structure to be a little more organized. The new test suites added are instrumentation for `xhr` and `requestAnimationFrame` Co-authored-by: Francesco Novy <[email protected]>
addition to #11655 Only the first regex group was used for the version variable which didn't allow pre-releases in the changelog.
ref #11084 This test ports `packages/browser/test/integration/suites/onunhandledrejection.js` playwright. Because of the same limitations as outlined with the on error tests #11666, I had to use calls to `window.onunhandledrejection` to simulate these tests instead of just using `Promise.reject` to test the handler. #11678 tracks being able to fix this so we can avoid directly calling `window.onunhandledrejection` to test. As `onunhandledrejection.js` was the last suite to use the old integration tests, I fully removed that code and the corresponding GH action workflow. I also removed the monorepo deps on `karma`, `chai` and `sinon`. Extremely satisfying.
Fixes #11755 OpenTelemetry restructured their http semantic conventions and declared them stable: https://opentelemetry.io/blog/2023/http-conventions-declared-stable/ This has unfortunately not been reflected in OpenTelemetry JS yet, blocked on them making everything backwards compat: open-telemetry/opentelemetry-js#4572 For now we can directly reference `http.request.method`, the replacement to `http.method`. When the OTEL SDK is finally updated to use proper conventions, we can avoid hard coding the string.
AbhiPrasad
approved these changes
Apr 24, 2024
size-limit report 📦
|
mydea
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.