This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add a built-in kernel test #576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that program manager throws an exception when actually trying to use built-in kernels, since they are not yet fully supported.
smaslov-intel
previously approved these changes
Nov 20, 2021
|
/verify with intel/llvm#4996 |
romanovvlad
reviewed
Nov 22, 2021
| @@ -0,0 +1,35 @@ | |||
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out | |||
There was a problem hiding this comment.
Can't we have this test in intel/llvm:sycl/unittests?
There was a problem hiding this comment.
I suppose so. Are you suggesting not performing a real device query at all and manually adding something into the program manager built-in kernel cache?
There was a problem hiding this comment.
It would be nice to check that sycl::device::get_info<sycl::info::device::built_in_kernel_ids> returns expected value if piDeviceGetInfo with CL_DEVICE_BUILT_IN_KERNELS returns non-empty list of kernels(we can emulate piDeviceGetInfo). And then check that an attempt to get a kernel bundle containing this kernel leads to exception.
|
Closing in favor of intel/llvm#5046. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that program manager throws an exception when actually trying to use built-in kernels, since they are not yet fully supported.
The corresponding fix in SYCL: intel/llvm#4996