Skip to content

[SYCL] Add a built-in kernel test #5046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2021
Merged

[SYCL] Add a built-in kernel test #5046

merged 2 commits into from
Dec 1, 2021

Conversation

dnmokhov
Copy link
Contributor

@dnmokhov dnmokhov commented Nov 30, 2021

  • Check device::get_info<info::device::built_in_kernel_ids>.
  • Check that an attempt to get a kernel bundle with built-in kernels leads to an exception, since they are not yet fully supported.

The above functionality was added in #4996.

- Check `device::get_info<info::device::built_in_kernel_ids>`.
- Check that an attempt to get a kernel bundle with built-in kernels leads to an exception, since they are not yet fully supported.

The above functionality was added in #4996.
alexbatashev
alexbatashev previously approved these changes Nov 30, 2021
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

steffenlarsen
steffenlarsen previously approved these changes Nov 30, 2021
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@dnmokhov dnmokhov dismissed stale reviews from steffenlarsen and alexbatashev via 9e1888f November 30, 2021 12:22
@vladimirlaz vladimirlaz merged commit d494595 into intel:sycl Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants