[SYCL] Add SYCL 2020 info::device::built_in_kernel_ids support #4996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `ProgramManager::getBuiltInKernelID`, which generates and caches built-in kernel IDs. - Use that API to generate or look up built-in kernel IDs, when queried. - Throw an exception in program manager when actually trying to use built-in kernels, since they are not yet fully supported. - Add SYCL 2020 deprecation warning for `built_in_kernels` (old query).
vladimirlaz
reviewed
Nov 20, 2021
| info::device::built_in_kernel_ids> { | ||
| static std::vector<kernel_id> get(RT::PiDevice dev, const plugin &Plugin) { | ||
| std::string result = | ||
| get_device_info<std::string, info::device::built_in_kernels>::get( |
There was a problem hiding this comment.
I think we will get the deprecation warning for info::device::built_in_kernels here.
There was a problem hiding this comment.
Since this is not a user-visible include file but is in sycl/source, our compiler should never be compiling this code, right?
There was a problem hiding this comment.
It is better to avoid warnings in RT library builds as well.
vladimirlaz
approved these changes
Nov 22, 2021
|
Waiting for CI results from intel/llvm-test-suite#576 (comment) before merging. |
steffenlarsen
approved these changes
Nov 22, 2021
vladimirlaz
pushed a commit
that referenced
this pull request
Dec 1, 2021
* [SYCL] Add a built-in kernel test - Check `device::get_info<info::device::built_in_kernel_ids>`. - Check that an attempt to get a kernel bundle with built-in kernels leads to an exception since they are not yet fully supported. The above functionality was added in #4996.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProgramManager::getBuiltInKernelID, which generates and caches built-in kernel IDs.built_in_kernels(old query).Test: intel/llvm-test-suite#576