[SYCL][ESIMD] Add unary and shift operators #3014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gang Y Chen <[email protected]>
bader
changed the title
|
@kbobrovs Please review |
|
@kychendev please review |
kychendev
reviewed
Jan 11, 2021
| DEF_BITWISE_OP(&, &=) | ||
| DEF_BITWISE_OP(|, |=) | ||
| DEF_BITWISE_OP(^, ^=) | ||
| DEF_BITWISE_OP(<<, <<=) |
There was a problem hiding this comment.
Looks good. I assume the underlying Clang vector operator will take care of integer promotion as expected.
Looks like the support for % and %= are still missing - could be added to the end of DEF_BINOP list @line 210.
kychendev
approved these changes
Jan 11, 2021
kbobrovs
approved these changes
Jan 11, 2021
| @@ -73,6 +73,16 @@ bool test_simd_bin_ops() __attribute__((sycl_device)) { | |||
| return v0[0] == 1; | |||
| } | |||
|
|
|||
| bool test_simd_unary_ops() __attribute__((sycl_device)) { | |||
There was a problem hiding this comment.
These tests are compile-only. Please create executable test as well in llvm-test-suite. Otherwise looks good to me.
|
@kbobrovs , please help me merge this PR. Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gang Y Chen [email protected]