[SYCL] Move free function queries to experimental namespace #4090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirlaz
suggested changes
Jul 12, 2021
vladimirlaz
suggested changes
Jul 12, 2021
| struct sub_group; | ||
| } | ||
| namespace experimental { | ||
| ONEAPI::sub_group this_sub_group(); |
There was a problem hiding this comment.
Suggested change
| ONEAPI::sub_group this_sub_group(); | |
| sycl::sub_group this_sub_group(); |
There was a problem hiding this comment.
This wouldn't work. sycl::sub_group is an alias to ONEAPI::sub_group, defined in sycl/sub_group.hpp, which in turn includes sycl/ONEAPI/sub_group.hpp. So, I'd either reference an undefined symbol or create a cyclic dependency.
I can add one more alias to sycl/ONEAPI/sub_group.hpp, if you'd like. It seems it doesn't lead to ODR violation or something.
|
Since these functions are a OneAPI extension, I think the namespace should be |
|
Makes sense to merge this PR after #4014 which introduces sycl::ONEAPI -> sycl::ext::oneapi transition. |
alexbatashev
force-pushed
the
free_function_queries_experimental
branch
from
3b9d43a to
5d39a3e
Compare
|
I've updated patch to conform to #4014 |
|
@intel/dpcpp-specification-reviewers @intel/llvm-reviewers-runtime ping |
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Jul 22, 2021
…ackend_plugin * upstream/sycl: (26 commits) [SPIR-V][NFC] Move non-upstreamed FuncParam decorations into internal:: (intel#4138) [SYCL] Move free function queries to experimental namespace (intel#4090) [SYCL][XPTI] Enable PI calls notifications with arguments (intel#4148) [SYCL] Revert queue::wait() to its old behaviour with Level Zero (intel#4153) [SYCL] Add missing <cstring> header to spirv.hpp (intel#4157) [SYCL] Adds info query for atomic_memory_order_capabilities on device and context (intel#4105) [SYCL] Improve performance of generic shuffles (intel#3815) [SYCL] Fix the error with namespaces caused during rebase of intel#4014 (intel#4151) [ESIMD] Fix 'ambiguous operator' error with length 1 simd operands (intel#4149) [libdevice][NFC] Fix libdevice dependencies list (intel#4130) [SPIR-V] Reland Encode debug info producer in SPIR-V (intel#4082) [SYCL][ROCm] Add ROCm support to get_device_count_by_type (intel#4113) [SYCL] Fix sRGB device info (intel#4145) [SYCL][ROCm] Fix kernel launch with multiple dimensions (intel#4063) [SYCL][ROCm] Fix compilation for AMD GPU with -fsycl-dead-args-optimization (intel#4126) [SYCL][Level Zero] Enable multi-CCS support. (intel#4038) [SYCL] Pass bound arch to unbundler (intel#4112) [ESIMD][doc] Added documentation for some ESIMD math APIs (intel#3995) [ESIMD] rename gather4/scatter4 to gather_rgba/scatter_rgba (intel#4120) [SYCL][NFC] Remove unused variable. (intel#4131) ...
romanovvlad
pushed a commit
that referenced
this pull request
Aug 19, 2021
#4090 moved free function queries to a different namespace. Host device implementation actually relies on integration header to extract information about free function queries and set the appropriate values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test changes are here: intel/llvm-test-suite#350