Skip to content

[NFC] Move non-upstreamed FuncParam decorations into internal:: #4138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2021
Merged

[NFC] Move non-upstreamed FuncParam decorations into internal:: #4138

merged 1 commit into from
Jul 22, 2021

Conversation

AGindinson
Copy link
Contributor

@AGindinson AGindinson commented Jul 19, 2021 •
edited
Loading

The decorations do not exist in KhronosGroup/SPIRV-LLVM-Translator, however will interfere
with the forthcoming pulldown of SPIR-V Headers changes. Therefore, the decorations should
be moved into the dedicated internal header.

Signed-off-by: Artem Gindinson [email protected]

@AlexeySachkov
Copy link
Contributor

@NikitaRudenkoIntel, can we remove those FuncParam*INTEL entries or they are still used by VC backend?

@bader
Copy link
Contributor

bader commented Jul 22, 2021

Typical contribution process for llvm-spirv tool is to commit changes to Khronos repository and pull them from there.
For pull requests like this with direct contribution, I expect justification to bypass regular process to be added to the pull request description.

@AlexeySachkov
Copy link
Contributor

Typical contribution process for llvm-spirv tool is to commit changes to Khronos repository and pull them from there.
For pull requests like this with direct contribution, I expect justification to bypass regular process to be added to the pull request description.

Modified code doesn't exists in upstream, because it does not conform to any of latest versions of our published specs and was introduced as a workaround for a VC backend to enable ESIMD feature. We didn't accept it in the translator upstream so it only landed here. I would love to get rid of it completely, but I don't know if that is possible

@AGindinson
Copy link
Contributor Author

AGindinson commented Jul 22, 2021 •
edited
Loading

I expect justification to bypass regular process to be added to the pull request description.

"Non-upstreamed" had been my lazy attempt to highlight the nuances @AlexeySachkov has expanded above :) I'll reflect this properly in the PR description.

@bader bader merged commit 66ef4eb into intel:sycl Jul 22, 2021
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Jul 22, 2021
@alexbatashev
Merge remote-tracking branch 'upstream/sycl' into xpti_sycl_version_b…
2e7f05d 
…ackend_plugin

* upstream/sycl: (26 commits)
  [SPIR-V][NFC] Move non-upstreamed FuncParam decorations into internal:: (intel#4138)
  [SYCL] Move free function queries to experimental namespace (intel#4090)
  [SYCL][XPTI] Enable PI calls notifications with arguments (intel#4148)
  [SYCL] Revert queue::wait() to its old behaviour with Level Zero (intel#4153)
  [SYCL] Add missing <cstring> header to spirv.hpp (intel#4157)
  [SYCL] Adds info query for atomic_memory_order_capabilities on device and context (intel#4105)
  [SYCL] Improve performance of generic shuffles (intel#3815)
  [SYCL] Fix the error with namespaces caused during rebase of intel#4014 (intel#4151)
  [ESIMD] Fix 'ambiguous operator' error with length 1 simd operands (intel#4149)
  [libdevice][NFC] Fix libdevice dependencies list (intel#4130)
  [SPIR-V] Reland Encode debug info producer in SPIR-V (intel#4082)
  [SYCL][ROCm] Add ROCm support to get_device_count_by_type (intel#4113)
  [SYCL] Fix sRGB device info (intel#4145)
  [SYCL][ROCm] Fix kernel launch with multiple dimensions (intel#4063)
  [SYCL][ROCm] Fix compilation for AMD GPU with -fsycl-dead-args-optimization (intel#4126)
  [SYCL][Level Zero] Enable multi-CCS support. (intel#4038)
  [SYCL] Pass bound arch to unbundler (intel#4112)
  [ESIMD][doc] Added documentation for some ESIMD math APIs (intel#3995)
  [ESIMD] rename gather4/scatter4 to gather_rgba/scatter_rgba (intel#4120)
  [SYCL][NFC] Remove unused variable. (intel#4131)
  ...
@AGindinson AGindinson deleted the internalize-func-param branch September 7, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@AlexeySotkin AlexeySotkin Awaiting requested review from AlexeySotkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AGindinson @AlexeySachkov @bader