Skip to content

[SYCL][ROCm] Fix compilation for AMD GPU with -fsycl-dead-args-optimization #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2021
Merged

[SYCL][ROCm] Fix compilation for AMD GPU with -fsycl-dead-args-optimization #4126

merged 3 commits into from
Jul 20, 2021

Conversation

AidanBeltonS
Copy link
Contributor

Prevents -emit-param-info being added if on AMD GPU

@AidanBeltonS AidanBeltonS changed the title Rocm emit param fix [SYCL][ROCm] emit param fix Jul 16, 2021
mdtoguchi
mdtoguchi reviewed Jul 16, 2021
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a small driver test that verifies that -emit-param-info isn't passed for the expected triple?

@AidanBeltonS
Copy link
Contributor Author

AidanBeltonS commented Jul 19, 2021 •
edited
Loading

Could you add a small driver test that verifies that -emit-param-info isn't passed for the expected triple?

Test has been added to check that -emit-param-info and -fenable-sycl-dae are not added for ROCm and CUDA
Test also checks that the flags are working when not ROCm and CUDA.

@AGindinson AGindinson requested a review from mdtoguchi July 19, 2021 17:17
mdtoguchi
mdtoguchi approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@bader bader changed the title [SYCL][ROCm] emit param fix [SYCL][ROCm] Fix compilation for AMD GPU with -fsycl-dead-args-optimization Jul 19, 2021
@bader bader merged commit 5ed48b4 into intel:sycl Jul 20, 2021
@AidanBeltonS AidanBeltonS deleted the rocm_emit-param-fix branch July 20, 2021 08:30
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Jul 22, 2021
@alexbatashev
Merge remote-tracking branch 'upstream/sycl' into xpti_sycl_version_b…
2e7f05d 
…ackend_plugin

* upstream/sycl: (26 commits)
  [SPIR-V][NFC] Move non-upstreamed FuncParam decorations into internal:: (intel#4138)
  [SYCL] Move free function queries to experimental namespace (intel#4090)
  [SYCL][XPTI] Enable PI calls notifications with arguments (intel#4148)
  [SYCL] Revert queue::wait() to its old behaviour with Level Zero (intel#4153)
  [SYCL] Add missing <cstring> header to spirv.hpp (intel#4157)
  [SYCL] Adds info query for atomic_memory_order_capabilities on device and context (intel#4105)
  [SYCL] Improve performance of generic shuffles (intel#3815)
  [SYCL] Fix the error with namespaces caused during rebase of intel#4014 (intel#4151)
  [ESIMD] Fix 'ambiguous operator' error with length 1 simd operands (intel#4149)
  [libdevice][NFC] Fix libdevice dependencies list (intel#4130)
  [SPIR-V] Reland Encode debug info producer in SPIR-V (intel#4082)
  [SYCL][ROCm] Add ROCm support to get_device_count_by_type (intel#4113)
  [SYCL] Fix sRGB device info (intel#4145)
  [SYCL][ROCm] Fix kernel launch with multiple dimensions (intel#4063)
  [SYCL][ROCm] Fix compilation for AMD GPU with -fsycl-dead-args-optimization (intel#4126)
  [SYCL][Level Zero] Enable multi-CCS support. (intel#4038)
  [SYCL] Pass bound arch to unbundler (intel#4112)
  [ESIMD][doc] Added documentation for some ESIMD math APIs (intel#3995)
  [ESIMD] rename gather4/scatter4 to gather_rgba/scatter_rgba (intel#4120)
  [SYCL][NFC] Remove unused variable. (intel#4131)
  ...
@bader bader added the hip Issues related to execution on HIP backend. label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdtoguchi mdtoguchi mdtoguchi approved these changes

@AGindinson AGindinson Awaiting requested review from AGindinson

Assignees
No one assigned
Labels
hip Issues related to execution on HIP backend.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AidanBeltonS @mdtoguchi @bader