Skip to content

[SYCL][FPGA] Silence unknown attribut warnings on Host compilation #5619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

smanna12
Copy link
Contributor

The compiler emits "unknown attribute" warnings during host compilation
for attributes:

  1. [[intel::num_simd_work_items()]]
  2. [[intel::kernel_args_restrict()]]
  3. [[intel::use_stall_enable_clusters]]
  4. [[intel::scheduler_target_fmax_mhz()]]
  5. [[intel::max_work_group_size()]]
  6. [[intel::max_global_work_dim()]]
  7. [[intel::bank_bits()]]

This patch marks the attributes in Attr.td with "SilentlyIgnoreSYCLIsHost",
so the diagnostic is not being issued on the host at all.

Signed-off-by: Soumi Manna [email protected]

The compiler emits "unknown attribute" warnings during host compilation
for attributes:
1. [[intel::num_simd_work_items()]]
2. [[intel::kernel_args_restrict()]]
3. [[intel::use_stall_enable_clusters]]
4. [[intel::scheduler_target_fmax_mhz()]]
5. [[intel::max_work_group_size()]]
6. [[intel::max_global_work_dim()]]
7. [[intel::bank_bits()]]

This patch marks the attributes in Attr.td with "SilentlyIgnoreSYCLIsHost",
so the diagnostic is not being issued on the host at all.

Signed-off-by: Soumi Manna <[email protected]>
@smanna12 smanna12 marked this pull request as ready for review February 20, 2022 21:34
@smanna12 smanna12 requested a review from a team as a code owner February 20, 2022 21:34
Signed-off-by: Soumi Manna <[email protected]>
@smanna12 smanna12 changed the title [SYCL] Silence unknown attribut warnings on Host compilation [SYCL][FPGA] Silence unknown attribut warnings on Host compilation Feb 21, 2022
Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@smanna12
Copy link
Contributor Author

ping @AaronBallman

Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I found a potential follow-up NFC commit.

@smanna12
Copy link
Contributor Author

smanna12 commented Feb 25, 2022

@bader, This PR is ready for merge. Thanks

@bader bader merged commit 2d359df into intel:sycl Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants