Merge from Azure/azure-powershell/master #21

jtlibing · 2016-11-17T08:48:15Z

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThrough parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

…ing document

Adding AuthenticodeSign verification task. Adding test for the task

…b changes

…ding module manifest, adding VS Dev command prompt with powershell, moving existing scripts that have been consolidated into module to a legacyscript directory

…test projects

NH change in sas Rules and Regenerate Key api : net sdk 2.0.0

Adding test framework documentation

platyPS documentation and Profile conversion

Add additional check to prevent null-reference exception

Fix storage account name hardcoded in diagnostics test files

…or to cmdlet processing and then asserting on the actual count. On CI the initial count was more than zero, but locally it is alwasy zero

ADL Updates to latest SDK in preparation for GA

Adding PsVersion to userAgent

- Administrators to Administrator - Included AnalysisServices module in AzureRM

powershel modules for AnalysisServices

[Release 3.1.0] Update change log and module manifest files

[Release 3.1.0] Merge release-3.1.0 -> master

* Need to check for null when creating Tags. * 1. Added new new param:TunnelConnectionStatus in output object:VirtualNetworkGatewayConnection and 2. Added new optional input param:gatewayVip in ResetGateway API. * Fix build error due to error in help file * Fixing bugs and modifying tests for analysis services commands - Added ServerFullName property to powershell type. - Modified tests to validate. * Incorporate review comments * revert back common.ps1 * Updated changeLog as per comments * Fix changeLog file * Bumping module version to 3.2.0 for AzureRm and AzureRm.Network

smithaborkar and others added 30 commits October 4, 2016 10:38

Merge remote-tracking branch 'refs/remotes/Azure/dev' into dev

9081063

Update CONTRIBUTING.md based on comments and rest-api-specs contribut…

526a8d6

…ing document

adding help content for Azure AS powershell

9fe8572

Updating the powershell installer with changes for AsAzure

c9fa64c

Reduced the folder path size

204e67b

Fixed the RecordsDirectory path

4f75ccc

Add alias to map AzureAuditLog datasource to AzureActivityLog

e1015a7

Including *.psm1 files to check authenticode signature

c4d5fb7

Merge pull request #3001 from shahabhijeet/2830SignIssue

e381a29

Adding AuthenticodeSign verification task. Adding test for the task

Renamed files and methods with new batch management lib 3.0

6e1946b

Update directory structure to match new names

1a456a5

Fix stale test framework reference

7099031

Update help for renamed quotas cmdlet

18493cc

Update Batch reference to latest

195e755

Move app package code into dedicated folders to reflect management li…

b45e391

…b changes

Rename application test from upload to add

b320c8b

Adding test framework documentation

a1fc9ed

Adding changes related suspend and resume

7547648

Add alias to Get-AzureRmBatchLocationQuotas cmdlet for back compat

b441fda

Consolidating basic command repository tasks into a script module. Ad…

db278a6

…ding module manifest, adding VS Dev command prompt with powershell, moving existing scripts that have been consolidated into module to a legacyscript directory

Adding project templates for AutoRest projects as well as PS and SDK …

80aed13

…test projects

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

149ed61

Merge pull request #3016 from smithab/dev

8bb0ea5

NH change in sas Rules and Regenerate Key api : net sdk 2.0.0

Fix Test-RecordSetEndsWithZoneName after it stopped working

4826026

Initial checkin for automating tests

2876a87

Merge pull request #3051 from Azure/docTestFramework

c25e837

Adding test framework documentation

Resolve code review feedback

a8d80c9

Merge pull request #2932 from cormacpayne/platyps-help

afa7cb0

platyPS documentation and Profile conversion

Merge pull request #3017 from michaelcohenmicrosoft/dev

c85ce80

Add additional check to prevent null-reference exception

Merge pull request #3049 from zhencui/dev

210a9a8

Fix storage account name hardcoded in diagnostics test files

athipp and others added 29 commits October 28, 2016 10:43

Updating Tests and Help

45651c3

Updating Tests

bbe1d3b

fixing tests

9a383de

Adding diagnostic message to get userAgent as well as it's Counts pri…

12df850

…or to cmdlet processing and then asserting on the actual count. On CI the initial count was more than zero, but locally it is alwasy zero

removing reference to tags and adding ref to analysisservices psd1

81535a2

Updating tests

ce715b7

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

a443f27

Address PR feedback.

d643911

Double check help, missed a force remove

3af7b46

Properly update types for GET

2532e3e

Accidentally unchecked in last commit for types

9831043

removing unnecessary dependencies

f30c654

regenerating test recorded json files

419a869

Updating Assert condition and adding more diagnostic traces

95d98f9

Updating/adjusting Trait categories

2d9df3e

Merge pull request #3152 from begoldsm/dev

8d62464

ADL Updates to latest SDK in preparation for GA

Merge pull request #3154 from Azure/psVerRel310

5a94020

Adding PsVersion to userAgent

Incorporating review comments

4548fce

fixing help file and psd1

d462714

Review comments

9bc0b22

- Administrators to Administrator - Included AnalysisServices module in AzureRM

Merge remote-tracking branch 'Azure/release-3.1.0' into dev

17eef8f

Merge pull request #3103 from athipp/dev

407c690

powershel modules for AnalysisServices

Add changes for release 3.1.0

8035561

Update change logs and module manifest files for release

86a4768

Revert changes that led to incorrect module versions

c2ff66a

Update change log versions for AzureStackAdmin and AzureStackStorage

4f7e230

Merge pull request #3159 from cormacpayne/update-logs

3d1beec

[Release 3.1.0] Update change log and module manifest files

Merge pull request #3163 from Azure/release-3.1.0

15bb4e1

[Release 3.1.0] Merge release-3.1.0 -> master

jtlibing merged commit a9cef22 into jtlibing:dev2 Nov 17, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge from Azure/azure-powershell/master #21

Merge from Azure/azure-powershell/master #21

Uh oh!

jtlibing commented Nov 17, 2016

Uh oh!

Uh oh!

Merge from Azure/azure-powershell/master #21

Merge from Azure/azure-powershell/master #21

Uh oh!

Conversation

jtlibing commented Nov 17, 2016

Description

General Guidelines

Testing Guidelines

Cmdlet Signature Guidelines

Cmdlet Parameter Guidelines

Uh oh!

Uh oh!