Skip to content

Merge from the Azure-powershell/dev #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 683 commits into from
Feb 24, 2017
Merged

Merge from the Azure-powershell/dev #23

merged 683 commits into from
Feb 24, 2017

Conversation

jtlibing
Copy link
Owner

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThrough parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

haitch and others added 30 commits January 11, 2017 18:16
* Need to check for null when creating Tags.

* Fixing bugs and modifying tests for analysis services commands

- Added ServerFullName property to powershell  type.
- Modified tests to validate.

* Add changelog.md and bumpup version

* Service management apis for ananlysis services.

* Updating target version in changelog.md

* Incorporating review comments

* fixing help file

* Adding help

* Remove unused .csproj file

* Changing ServiceManagement to Dataplane

* Changing parameter name for login command

* Updating xml help file

* Removing old help files

* Adding Inmemory tests for Dataplane API
Renaming EnivronmentName parameter to RolloutEnvironment
Fixing other review comments.

* Fixing a build issue

* Fixing bugs

* Review comments and bug fix

* Bug fixes

* Fixing build break

* adding ignored file.

* fixing review comments

* Remove dll-help file from wxi project

* Removing invalid ref

* Revert "Removing invalid ref"

This reverts commit 27c95dc.

* Revert "Remove dll-help file from wxi project"

This reverts commit f886901.

* Bringing back the dll-help files

* adding back reference to dll-help file

* Platyps based help files for analysis services

* Resolving comments
* Fix Get-AzureRmVM issue (#3372)

* Update AzureRM.Compute changelog.
1. Move all logging related logic into the logger constructor and
dispose() methods to reduce duplication
2. Add parameter sets for diagnostic logging and make the log path
required. Also update the default log level to be Error (the least
verbose logging that actually logs, since None does not log).
3. Updated help to reflect these changes.
4. Removed parameter sets from passthru.
ADL Updates for Jan release
)

* Adding Analysis Service Dataplane module to AzureRm rollup module

* Update AzureRM.psd1

Removing extra tab that resulted in misalignment

* Update PublishModules.ps1

aligning
[Release 3.4.0] Update module versions for release
Remove AzureAuditLog as a valid kind of datasource as it's been replaced by AzureActivityLog
Adding missing services Data Lake Store and Data Lake Analytics to the repo's README.md file.
Remove-AzureRmSqlDatabaseAuditing should set the UseServerDefault value
to false
[Release 3.4.0] Update change logs and psd1 files for release
[Release 3.4.0] Merge release --> master
ziwa-msft and others added 29 commits February 17, 2017 12:26
…s to Update-AzureRmDiagnosticSettings in the upcoming breaking changes doc
[Release 3.6.0] Update module versions for February release
[Release 3.6.0] Fixed network solution with broken tests (does not affect product packages).
Allow insights powershell to unselect data sinks in diagnosticsettings.
[Release 3.6.0] Fix build error with Network project
…nto release-3.6.0

# Conflicts:
#	src/ResourceManager/Network/Network.sln
#	src/ResourceManager/Sql/AzureRM.Sql.psd1
* Explained how to create service principal

Also made several other minor formatting edits

* Fixed formatting around Service Principal conn str

* Updated Nuget instructions
[Release 3.6.0] Update change logs for release
[Release 3.6.0] Merge release --> master
[Release 3.6.0] Merge master --> dev
@jtlibing jtlibing merged commit 6694167 into jtlibing:dev Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.