Prepare for v0.6.1 #1042
Merged
Prepare for v0.6.1 #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ruromero <[email protected]>
Signed-off-by: ruromero <[email protected]>
There is a set of cases where ppl might want to wrap the defaultNewClient, for example: * To force dry run (currently possible via a manager opt) * To enforce usage of a given namespace
✨ Manager: Export defaultNewClient
🐛 cannot specify ControlPlane in envtest.Environment
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: ruromero <[email protected]>
The controller contains the unused Config attribute. Since its exported, linters will not complain about it, but since its in an internal package, it is not part of our public api.
🏃 Remove unsed Config attribute from controller
🐛 Reset resource version if fake client Create call failed
Currently, the controller gets a cache injected and waits for that cache to sync before starting workers. This model works well for single cluster usecases, but doesn't work at all for multi-cluster usecases, as the source may be using a completely different cache. This PR adds a new source.SyncingSource interface and makes the controller wait for all sources that implement it. Apart from solving the issue mentioned in the title, this also allows to implement custom sources that need syncing.
Add a gauge for requests currently being handled and a counter for the total amount of requests processed. Used [prometheus/promhttp](https://pkg.go.dev/github.com/prometheus/client_golang/prometheus/promhttp?tab=doc) package which provides nice decorators for `Http.Handler` to handle the metrics instead of the custom code.
✨ Controller: Let sources sync even if they use a different cluster
This created to much noise and broke BC.
Signed-off-by: ialidzhikov <[email protected]>
✨ Introduce controllerutil.Object interface
🐛 Fix scheme used by `DeleteAllOf` in fake client
📖 Prevent errors to be logged multiple times in builtins example
Signed-off-by: knight42 <[email protected]>
✨ Add ContainsFinalizer helper to the controllerutil
…erutil.Object and deprecate *WithError funcs
✨ Migrate controllerutil AddFinalizer and RemoveFinalizer to controllerutil.Object and deprecate *WithError functions
…d gopkg.in/fsnotify.v1 Signed-off-by: Pierre Péronnet <[email protected]>
🐛 fix(dependency) Use github.com/fsnotify/fsnotify
Signed-off-by: Vince Prignano <[email protected]>
📖 Nit: improve doc string
🏃 Remove unused attributes from controller
🏃 Move pwittrock from emeritus approvers to approvers
Signed-off-by: Vince Prignano <[email protected]>
Signed-off-by: Vince Prignano <[email protected]>
[0.6] Update go.mod dependencies patch versions (v0.18.4)
Signed-off-by: Vince Prignano <[email protected]>
🏃 Cleanup controller internal logger
See kubernetes/kubernetes#92069 Signed-off-by: Vince Prignano <[email protected]>
🏃 Clarify log line in apiutil.GVKForObject
🏃 Update json-patch dependency to e83c0a1c26c8
Trying to use a zeroed Manager results in immediate panic on startup, so let's create it properly. Signed-off-by: Morten Siebuhr <[email protected]>
🐛 Fix webhook example
feat:remove the whitelist word from our codebase
feat:Remove master word from our codebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test pull-controller-runtime-test-release-0-6 |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @alvaroaleman