Release for v0.5.1 #851
Merged
Release for v0.5.1 #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vincepri
commented
Mar 10, 2020
vincepri
commented
- sourceWithFixedCache does not implement InjectCache - it does not rely on the current implicit implementation that a cache is not overwriting in case it was injected before - see kubernetes-sigs#650 Co-authored-by: Ralf Pannemans <[email protected]>
Co-authored-by: Ulrich Kramer <[email protected]>
✨ Create a supported way of setting a cache on source.Kind
Signed-off-by: Vince Prignano <[email protected]>
Add vincepri to maintainers
Closely matches the NameGenerator from APIServer
Exposes rate limiter as a controller option in case users want to use a different rate limiter than the default one provided by controller-runtime.
✨ support restconfig to target the control plane
🏃 Update linter and lint fixes
When the list type is already a pointer this code results in a cache type of **Type which can't be cast to runtime.Object. This adds a check to the function to only grab a pointer to a type if it is not already a ptr type.
commits remove the testutil.go file which is commented and no longer required. Signed-off-by: prateekpandey14 <[email protected]>
…m-file 🐛 remove unused commented out testutil.go
…name 🐛 Use GenerateName during fake client's Create method
Signed-off-by: Chris Hein <[email protected]>
…-design-folder ✨📖 Adding designs folder and sample template
🏃 prune any use of xerrors
…inter-for-non-pointers-only-with-test 🐛 Fix informer cache creating pointers to pointers
Update documentation for the metrics package to enumerate all exposed metrics with an explanation of what they capture.
Passing the context down to the `ip.InformersMap.Get()` makes it possible to handle scenarios where the cache takes too long to sync or will never sync.
…ate according to the given CAName
✨ Take context when getting informer.
Signed-off-by: Vince Prignano <[email protected]>
Signed-off-by: Vince Prignano <[email protected]>
📖 document exposed metrics
Signed-off-by: Vince Prignano <[email protected]>
…-ref ✨ Add controllerutil.EnsureOwnerReference
…s-tools 🏃 Add verification tools, linter and modules
🏃 Use scheme.Convert to convert unstructrured objects
Add shawn-hurley to approvers
…-limit ✨Make workqueue rate limiter configurable during controller creation
…k-support-mtls ✨enable webhook server set-up mTLS service to verify client's certificate
Co-authored-by: Solly Ross <[email protected]>
⚠ (:warning:, major) Webhook support in envtest
Those coming across controller-runtime because they want to write their own controller may really want to use kubebuilder to get started.
🐛 Fix testdata imports in pkg/webhook/conversion
📖 reference kubebuilder in README
Signed-off-by: Vince Prignano <[email protected]>
🏃Rename EnsureOwnerReference to SetOwnerReference for consistency
k8s-ci-robot
added
size/XXL
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.