Skip to content

[LangRef] Document the fourth operand for vp.cttz/ctlz. NFC #97387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Jul 2, 2024

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Jul 2, 2024

@llvm/pr-subscribers-llvm-ir

Author: Craig Topper (topperc)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/97387.diff

1 Files Affected:

  • (modified) llvm/docs/LangRef.rst (+6-2)
diff --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst
index e2c47204e628f..ed988e48daa09 100644
--- a/llvm/docs/LangRef.rst
+++ b/llvm/docs/LangRef.rst
@@ -24503,7 +24503,9 @@ Arguments:
 The first operand and the result have the same vector of integer type. The
 second operand is the vector mask and has the same number of elements as the
 result vector type. The third operand is the explicit vector length of the
-operation.
+operation. The fourth operand is a constant flag that indicates whether the
+intrinsic returns a valid result if the first operand is zero. If the first
+operand is zero and the fourth operand is true, the result is poison.
 
 Semantics:
 """"""""""
@@ -24550,7 +24552,9 @@ Arguments:
 The first operand and the result have the same vector of integer type. The
 second operand is the vector mask and has the same number of elements as the
 result vector type. The third operand is the explicit vector length of the
-operation.
+operation. The fourth operand is a constant flag that indicates whether the
+intrinsic returns a valid result if the first operand is zero. If the first
+operand is zero and the fourth operand is true, the result is poison.
 
 Semantics:
 """"""""""

Copy link
Collaborator

@RKSimon RKSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - with one minor peeve - the subsection is called "Arguments:" but then we refer to them as operands :\

@topperc
Copy link
Collaborator Author

topperc commented Jul 2, 2024

LGTM - with one minor peeve - the subsection is called "Arguments:" but then we refer to them as operands :\

Yeah I noticed that too. Its all over the VP intrinsics. Maybe I'll do a bulk rename.

@topperc topperc merged commit e414bf9 into llvm:main Jul 2, 2024
8 of 10 checks passed
@topperc topperc deleted the pr/vp-cttz-ctlz branch July 2, 2024 16:26
topperc added a commit to topperc/llvm-project that referenced this pull request Jul 2, 2024
…s. NFC

Fixes inconsistencies noted in llvm#97386 and llvm#97387.

There are still more intrinsics that have the same issue. I might
submit more patches for those.
topperc added a commit that referenced this pull request Jul 2, 2024
…sics. NFC (#97437)

Fixes inconsistencies noted in #97386 and #97387.

There are still more intrinsics that have the same issue. I might submit
more patches for those.
lravenclaw pushed a commit to lravenclaw/llvm-project that referenced this pull request Jul 3, 2024
lravenclaw pushed a commit to lravenclaw/llvm-project that referenced this pull request Jul 3, 2024
…sics. NFC (llvm#97437)

Fixes inconsistencies noted in llvm#97386 and llvm#97387.

There are still more intrinsics that have the same issue. I might submit
more patches for those.
kbluck pushed a commit to kbluck/llvm-project that referenced this pull request Jul 6, 2024
kbluck pushed a commit to kbluck/llvm-project that referenced this pull request Jul 6, 2024
…sics. NFC (llvm#97437)

Fixes inconsistencies noted in llvm#97386 and llvm#97387.

There are still more intrinsics that have the same issue. I might submit
more patches for those.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants