Skip to content

[Fortran/gfortran] Enable tests that now pass #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

tarunprabhu
Copy link
Contributor

This is likely to be dependent on another PR.

@jeanPerier attempted to enable several of these tests once before, but there were issues with the not utility in the test suite that prevented the tests from being enabled then. The first PR linked above should have fixed those, so once that lands, these tests should also work.

Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. All passes for me now

@tarunprabhu tarunprabhu force-pushed the enable-passing-tests branch from f04c1a6 to 454055b Compare July 25, 2024 13:33
@tarunprabhu
Copy link
Contributor Author

@tblah, @AlexisPerry,

#142 was just merged. Do you mind checking this again now? Perhaps I'm being a bit overcautious. Thanks!

@tblah
Copy link
Contributor

tblah commented Jul 25, 2024

Still works for me

@tarunprabhu tarunprabhu merged commit 7922947 into llvm:main Jul 25, 2024
@tarunprabhu tarunprabhu deleted the enable-passing-tests branch July 25, 2024 16:51
@antmox
Copy link
Contributor

antmox commented Aug 1, 2024

Hi @tarunprabhu, @tblah, @jeanPerier,
It looks like some of our bots are broken since this commit:
clang-aarch64-full-2stage https://lab.llvm.org/buildbot/#/builders/84/builds/480
clang-aarch64-sve-vla-2stage https://lab.llvm.org/buildbot/#/builders/41/builds/903
clang-aarch64-sve-vls-2stage https://lab.llvm.org/buildbot/#/builders/4/builds/937
clang-aarch64-sve-vla https://lab.llvm.org/buildbot/#/builders/17/builds/1349
clang-aarch64-sve-vls https://lab.llvm.org/buildbot/#/builders/143/builds/917
I still dont understand why all these NOEXE errors, but it seems that at least internal_dummy_2.f08 cannot be re-enabled.
Could you please look at this ?

@tarunprabhu
Copy link
Contributor Author

I'm taking a look now.

@tarunprabhu
Copy link
Contributor Author

tarunprabhu commented Aug 1, 2024

@antmox

The NOEXE errors don't seem to be coming from the fortran tests, so I can't really speak to those. I could not replicate the error on the AArch64 machine to which I have access.

Based on an exchange with @tblah and @kiranchandramohan, the failure may occur if compiler-rt is not available. Is this the case with these build bots?

[EDIT: grammar]

antmox added a commit to antmox/llvm-test-suite that referenced this pull request Aug 2, 2024
Fortran/gfortran/regression/gfortran-regression-execute-regression__do_check_1_f90.test
still fails after being re-enabled in llvm#143
  https://lab.llvm.org/buildbot/#/builders/143/builds/1198
antmox added a commit that referenced this pull request Aug 2, 2024
Fortran/gfortran/regression/gfortran-regression-execute-regression__do_check_1_f90.test
still fails after being re-enabled in #143
  https://lab.llvm.org/buildbot/#/builders/143/builds/1198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants