-
Notifications
You must be signed in to change notification settings - Fork 350
[Fortran/gfortran] Enable tests that now pass #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. All passes for me now
f04c1a6
to
454055b
Compare
#142 was just merged. Do you mind checking this again now? Perhaps I'm being a bit overcautious. Thanks! |
Still works for me |
Hi @tarunprabhu, @tblah, @jeanPerier, |
I'm taking a look now. |
The Based on an exchange with @tblah and @kiranchandramohan, the failure may occur if compiler-rt is not available. Is this the case with these build bots? [EDIT: grammar] |
Fortran/gfortran/regression/gfortran-regression-execute-regression__do_check_1_f90.test still fails after being re-enabled in llvm#143 https://lab.llvm.org/buildbot/#/builders/143/builds/1198
Fortran/gfortran/regression/gfortran-regression-execute-regression__do_check_1_f90.test still fails after being re-enabled in #143 https://lab.llvm.org/buildbot/#/builders/143/builds/1198
This is likely to be dependent on another PR.
@jeanPerier attempted to enable several of these tests once before, but there were issues with the
not
utility in the test suite that prevented the tests from being enabled then. The first PR linked above should have fixed those, so once that lands, these tests should also work.