Prepare 0.7.4 release #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation link is pretty far below, which is unfortunate as so much time went into making a beautiful docs page. I think it's good to have all important project links easily accessible at the top and badges are a nice way to do it.
Noticed that a few of these weren't noted, but got them together from the CircleCI workflow. Also moved the test section up as I think the most important thing after setting up to see that it works is running the tests. Kinda deprecates/clashes with #324 as I changed where that note is displayed and how it's incorporated so that it's no longer needed.
Add docs badge, thank you @PragTob !
I'm unsure as of now if there ae other and/or better places to send them to.
Before it was rather confusing for me as other component doesn't use some component and later also isn't used in the page so it was rather difficult to find out how both components end up in the page. I hope that by reversing the order of the components so that first people are introduced to other_component, which is then used in some component which is then used in the page this is made more understandable. Also added another note mentioning this.
Improve Setup instructions for Contributions
Note the link doesn't quite work yet to its fullest extent because of matestack/matestack-docs#34
Point people to concepts after they finished the installation
Adjust the order in which components are provided
…amic-components Point people to dynamix components
Point people to how to remove turbolinks to be nice
Async docs: explicitly mention that the timespans used are in milliseconds
Name is WIP as right now raw clashes with the raw of Rails, which would give us the desired result (which is nice) but might be a worse choice if there were some common options etc. we wanted to use or just well... consistency :)
In async actions the view context doesn't seem to be available, from where html_escape was called before. So we explicitly call out to it now. Also improved some error reporting, that before was just swalloing errors without a proper stacktrace or real error.
Add code of conduct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.