Skip to content

Allow escape and ctrl+U to clear the interactive window #10513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2020
Merged

Allow escape and ctrl+U to clear the interactive window #10513

merged 4 commits into from
Mar 10, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Mar 10, 2020

For #10198

@rchiodo rchiodo self-assigned this Mar 10, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Mar 10, 2020 •
edited
Loading

Codecov Report

Merging #10513 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10513      +/-   ##
==========================================
- Coverage   60.86%   60.82%   -0.04%     
==========================================
  Files         579      579              
  Lines       31294    31302       +8     
  Branches     4451     4452       +1     
==========================================
- Hits        19046    19040       -6     
- Misses      11285    11296      +11     
- Partials      963      966       +3
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...ient/datascience/jupyter/kernels/kernelSelector.ts 76.37% <0.00%> (-1.23%) ⬇️
...active-common/intellisense/intellisenseProvider.ts 37.09% <0.00%> (-0.74%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd90761...a60617b. Read the comment docs.

@rchiodo rchiodo merged commit 3a0fa48 into master Mar 10, 2020
@rchiodo rchiodo deleted the rchiodo/escape_terminal branch March 10, 2020 23:53
DonJayamanne added a commit that referenced this pull request Mar 13, 2020
@DonJayamanne
Merge branch 'master' into ds/custom_editor
d3c4ad9 
* master:
  Fix flakey file system tests (#10541)
  Tweaks for gather (#10532)
  Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517)
  Add conda support to nightly flake test (#10523)
  Rename datascience to datascience_modules (#10525)
  Clean up the extension activation code. (#10455)
  Allow escape and ctrl+U to clear the interactive window (#10513)
  Fix builtins so they don't interfere with our execution (#10511)
  Jupyter autocompletion will only show up on empty lines, (#10420)
  notify on missing kernel and interpreter with kernel (#10508)
@lock lock bot locked as resolved and limited conversation to collaborators Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DavidKutu DavidKutu DavidKutu approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

Assignees

@rchiodo rchiodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rchiodo @codecov-io @IanMatthewHuff @DavidKutu