Skip to content

Rename datascience to datascience_modules #10525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2020
Merged

Rename datascience to datascience_modules #10525

merged 2 commits into from
Mar 11, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Mar 11, 2020

Seems there's a popular module called 'datascience' already.

This should fix this bug here:
microsoft/vscode#92511

@rchiodo rchiodo self-assigned this Mar 11, 2020
DonJayamanne
DonJayamanne requested changes Mar 11, 2020
View reviewed changes
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some parts of the python code need to be changed as well,

vscode-python/pythonFiles/datascience_modules/jupyter_daemon.py

Line 9 in 3e3fb6f

from datascience.daemon.daemon_python import (

Might want to do a search for datascience.daemon.

@IanMatthewHuff
Copy link
Member

I think that our chance of collision is now way lower. But my vote here would be that we have something either Microsoft or vscode specific in the name. "datascience_modules" still doesn't seem outside of the realm of possibility for someone to want to have their own module of. I think something like "vscode_datascience" or "vscode_datascience_modules" or "vscode_python_extension" is safer, but I'm not sure if that's just too much caution.

@DonJayamanne
Copy link

I agree with @IanMatthewHuff

IanMatthewHuff
IanMatthewHuff requested changes Mar 11, 2020
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More specific name from "datascience_modules"

@rchiodo rchiodo added the no-changelog No news entry required label Mar 11, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@codecov-io
Copy link

codecov-io commented Mar 11, 2020 •
edited
Loading

Codecov Report

Merging #10525 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10525      +/-   ##
==========================================
- Coverage   60.81%   60.79%   -0.02%     
==========================================
  Files         578      578              
  Lines       31288    31288              
  Branches     4451     4451              
==========================================
- Hits        19029    19023       -6     
- Misses      11295    11299       +4     
- Partials      964      966       +2
Impacted Files Coverage Δ
.../datascience/jupyter/interpreter/jupyterCommand.ts 55.17% <ø> (ø) ⬆️
src/client/datascience/jupyter/jupyterVariables.ts 50.57% <0%> (ø) ⬆️
src/client/datascience/constants.ts 99.71% <100%> (ø) ⬆️
...er/jupyterInterpreterSubCommandExecutionService.ts 83.33% <100%> (ø) ⬆️
...reter/jupyterCommandInterpreterExecutionService.ts 68.88% <100%> (ø) ⬆️
src/client/common/process/pythonDaemonPool.ts 70.58% <100%> (ø) ⬆️
src/datascience-ui/react-common/arePathsSame.ts 75% <0%> (-12.5%) ⬇️
src/client/common/utils/platform.ts 64.7% <0%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0%> (-1.57%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8267781...53f83ab. Read the comment docs.

@rchiodo rchiodo merged commit 66a9333 into master Mar 11, 2020
@rchiodo rchiodo deleted the rchiodo/rename_datascience branch March 11, 2020 21:35
rchiodo added a commit that referenced this pull request Mar 11, 2020
@rchiodo
Rename datascience to datascience_modules (#10525)
5c02a19 
* Rename datascience to datascience_modules

* Change name to something even harder to get wrong
rchiodo added a commit that referenced this pull request Mar 12, 2020
@rchiodo
Rename datascience to datascience_modules (#10525) (#10528)
f7cf79b 
* Rename datascience to datascience_modules (#10525)

* Rename datascience to datascience_modules

* Change name to something even harder to get wrong

* Fix unit test failure for release
DonJayamanne added a commit that referenced this pull request Mar 13, 2020
@DonJayamanne
Merge branch 'master' into ds/custom_editor
d3c4ad9 
* master:
  Fix flakey file system tests (#10541)
  Tweaks for gather (#10532)
  Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517)
  Add conda support to nightly flake test (#10523)
  Rename datascience to datascience_modules (#10525)
  Clean up the extension activation code. (#10455)
  Allow escape and ctrl+U to clear the interactive window (#10513)
  Fix builtins so they don't interfere with our execution (#10511)
  Jupyter autocompletion will only show up on empty lines, (#10420)
  notify on missing kernel and interpreter with kernel (#10508)
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@DavidKutu DavidKutu DavidKutu approved these changes

Assignees

@rchiodo rchiodo

Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rchiodo @IanMatthewHuff @DonJayamanne @codecov-io @DavidKutu