Skip venv tests for 2.7 and disable fail fast #11546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimadeline
reviewed
May 1, 2020
kimadeline
reviewed
May 2, 2020
src/test/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.ts
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #11546 +/- ##
==========================================
- Coverage 60.45% 60.43% -0.02%
==========================================
Files 618 618
Lines 33774 33774
Branches 4763 4763
==========================================
- Hits 20419 20413 -6
- Misses 12347 12351 +4
- Partials 1008 1010 +2
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
karrtikr
approved these changes
May 2, 2020
kimadeline
approved these changes
May 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not be running
venvtests for 2.7, sincevenvis not supported on 2.7.