Skip to content

Enable drd and helgrind in the valgrind jobs #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Feb 6, 2024

Enable drd and helgrind in the valgrind jobs.

Fixes: #156
Fixes: #157

@ldorau ldorau force-pushed the Enable_drd_and_helgrind_in_the_Nightly_CI_job branch from 22c4de7 to 5a7fa50 Compare February 6, 2024 15:14
@igchor
Copy link
Member

igchor commented Feb 7, 2024

Do we actually want to run drd and helgrind tests? We already have tsan which cover most (I think) of the things checked by drd/helgrind and tsan has better support for the standard library. Also, it seems that it does not report any false positives for jemalloc/tbb.

@bratpiorka
Copy link
Contributor

@igchor The question is how many of these problems found are real. We have already run TSAN, which reports no problems, so if it turns out that ALL drd/helgrind problems are false positives, then I agree that running TSAN is sufficient - there is no point in maintaining a false-positive-only suppression list. I think the next step should be to merge this PR, close issues 156 + 157 and add a new issues for drd/helgrind results (with a note that we should possibly remove it if it makes sense).

@ldorau ldorau closed this Feb 22, 2024
@ldorau ldorau deleted the Enable_drd_and_helgrind_in_the_Nightly_CI_job branch February 22, 2024 14:04
@ldorau ldorau restored the Enable_drd_and_helgrind_in_the_Nightly_CI_job branch February 22, 2024 14:05
@ldorau ldorau reopened this Feb 22, 2024
@ldorau ldorau force-pushed the Enable_drd_and_helgrind_in_the_Nightly_CI_job branch 3 times, most recently from 9c8b73b to fd000de Compare February 27, 2024 09:13
@ldorau ldorau force-pushed the Enable_drd_and_helgrind_in_the_Nightly_CI_job branch 3 times, most recently from 6e77788 to e74b695 Compare March 15, 2024 09:05
@ldorau ldorau changed the title [DRAFT] Enable drd and helgrind in the Nightly CI job Enable drd and helgrind in the valgrind jobs Mar 15, 2024
@ldorau ldorau marked this pull request as ready for review March 15, 2024 09:30
@ldorau ldorau requested a review from a team as a code owner March 15, 2024 09:30
@ldorau ldorau requested review from bratpiorka and igchor March 15, 2024 09:30
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a link to your execution of this or possibly run this workflow on push trigger to see the output

nevermind, I didn't see your prev. PR enabling Valgrind on PR.

@ldorau
Copy link
Contributor Author

ldorau commented Mar 15, 2024

pls add a link to your execution of this or possibly run this workflow on push trigger to see the output

nevermind, I didn't see your prev. PR enabling Valgrind on PR.

@lukaszstolarczuk So is it OK now ?

@ldorau ldorau requested a review from lukaszstolarczuk March 15, 2024 13:46
@ldorau ldorau force-pushed the Enable_drd_and_helgrind_in_the_Nightly_CI_job branch from e74b695 to 95a76b9 Compare March 15, 2024 17:08
@ldorau
Copy link
Contributor Author

ldorau commented Mar 15, 2024

Rebased

@ldorau ldorau force-pushed the Enable_drd_and_helgrind_in_the_Nightly_CI_job branch from 95a76b9 to 68dad1e Compare March 18, 2024 07:34
@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft March 18, 2024 10:26
@ldorau ldorau force-pushed the Enable_drd_and_helgrind_in_the_Nightly_CI_job branch 2 times, most recently from 7abdc0b to 1ec8bfb Compare March 18, 2024 11:41
@ldorau ldorau marked this pull request as ready for review March 18, 2024 11:52
@igchor
Copy link
Member

igchor commented Mar 18, 2024

I think there is some problem with the script. When I run test_valgrind.sh everything is reported as "PASSED" but when I run valgrind manually (valgrind --tool=memcheck ./test/umf_test-jemalloc_pool) then it reports errors without the suppresions.

Copy link
Member

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify that the script works correctly. Valgrind still fails on my machine.

@ldorau ldorau force-pushed the Enable_drd_and_helgrind_in_the_Nightly_CI_job branch from 1ec8bfb to d64f446 Compare March 18, 2024 18:32
@ldorau ldorau marked this pull request as draft March 18, 2024 19:49
@ldorau ldorau force-pushed the Enable_drd_and_helgrind_in_the_Nightly_CI_job branch 3 times, most recently from ebe9a32 to 4de5332 Compare March 19, 2024 13:27
@ldorau ldorau force-pushed the Enable_drd_and_helgrind_in_the_Nightly_CI_job branch from 4de5332 to 38e2586 Compare March 19, 2024 14:32
@ldorau ldorau marked this pull request as ready for review March 19, 2024 14:33
@ldorau ldorau requested a review from igchor March 19, 2024 14:33
@ldorau
Copy link
Contributor Author

ldorau commented Mar 19, 2024

@igchor the script works correctly now

@bratpiorka
Copy link
Contributor

@igchor could you confirm?

@igchor
Copy link
Member

igchor commented Mar 19, 2024

@igchor could you confirm?

Yes, it looks good now. The tests fail without the suppressions as expected.

@ldorau ldorau merged commit d1ec2e1 into oneapi-src:main Mar 20, 2024
@ldorau ldorau deleted the Enable_drd_and_helgrind_in_the_Nightly_CI_job branch March 20, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all valgrind-helgrind errors in the tests Fix all valgrind-drd errors in the tests
5 participants