-
Notifications
You must be signed in to change notification settings - Fork 35
Enable drd and helgrind in the valgrind jobs #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable drd and helgrind in the valgrind jobs #216
Conversation
22c4de7
to
5a7fa50
Compare
Do we actually want to run drd and helgrind tests? We already have tsan which cover most (I think) of the things checked by drd/helgrind and tsan has better support for the standard library. Also, it seems that it does not report any false positives for jemalloc/tbb. |
@igchor The question is how many of these problems found are real. We have already run TSAN, which reports no problems, so if it turns out that ALL drd/helgrind problems are false positives, then I agree that running TSAN is sufficient - there is no point in maintaining a false-positive-only suppression list. I think the next step should be to merge this PR, close issues 156 + 157 and add a new issues for drd/helgrind results (with a note that we should possibly remove it if it makes sense). |
9c8b73b
to
fd000de
Compare
6e77788
to
e74b695
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add a link to your execution of this or possibly run this workflow on push
trigger to see the output
nevermind, I didn't see your prev. PR enabling Valgrind on PR.
@lukaszstolarczuk So is it OK now ? |
e74b695
to
95a76b9
Compare
Rebased |
95a76b9
to
68dad1e
Compare
7abdc0b
to
1ec8bfb
Compare
I think there is some problem with the script. When I run test_valgrind.sh everything is reported as "PASSED" but when I run valgrind manually (valgrind --tool=memcheck ./test/umf_test-jemalloc_pool) then it reports errors without the suppresions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify that the script works correctly. Valgrind still fails on my machine.
1ec8bfb
to
d64f446
Compare
ebe9a32
to
4de5332
Compare
Fixes: oneapi-src#156 Fixes: oneapi-src#157 Signed-off-by: Lukasz Dorau <[email protected]>
4de5332
to
38e2586
Compare
@igchor the script works correctly now |
@igchor could you confirm? |
Yes, it looks good now. The tests fail without the suppressions as expected. |
Enable drd and helgrind in the valgrind jobs.
Fixes: #156
Fixes: #157