Merge v0.10.x into main #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update 3rd party programs file (uthash, google bench)
Update umfOpenIPCHandle API to use IPC handler instead of pool
Disable not used hwloc feature "rsmi". Silence errors during hwloc linkage to umf, like: /usr/bin/ld: _deps/hwloc_targ-build/lib/libhwloc.a(topology-rsmi.o): in function `get_device_name': topology-rsmi.c:(.text+0x208): undefined reference to `rsmi_dev_name_get'
1) Do not check coverage in the Release multi-numa build 2) Unify the name of the coverage data file in the `upload-artifact` step and the coverage artifact file in the `Check coverage` step. A name of the coverage artifact file in the `Check coverage` step must be unique. Signed-off-by: Lukasz Dorau <[email protected]>
…ata_files Do not check coverage in the Release multi-numa build
Remove incorrect assert in utils_align_ptr_up_size_down(). A pointer is aligned, but a size is only adjusted to the new pointer. The size does not have to be aligned. Signed-off-by: Lukasz Dorau <[email protected]>
Disable rsmi in hwloc build
Signed-off-by: Lukasz Dorau <[email protected]>
lukaszstolarczuk
force-pushed
the
merge-v0.10.x-into-main
branch
from
d993b6d to
2803ebd
Compare
ldorau
requested changes
Dec 10, 2024
There was a problem hiding this comment.
D:\a\unified-memory-framework\unified-memory-framework\test\ipcFixtures.hpp(535,22): error C2220: the following warning is treated as an error [D:\a\unified-memory-framework\unified-memory-framework\build\test\umf_test-ipc.vcxproj]
(compiling source file '../../test/ipcAPI.cpp')
D:\a\unified-memory-framework\unified-memory-framework\test\ipcFixtures.hpp(535,22): warning C4456: declaration of 'ret' hides previous local declaration [D:\a\unified-memory-framework\unified-memory-framework\build\test\umf_test-ipc.vcxproj]
(compiling source file '../../test/ipcAPI.cpp')
D:\a\unified-memory-framework\unified-memory-framework\test\ipcFixtures.hpp(477,18):
see declaration of 'ret'
…_in_utils_align_ptr_up_size_down Fix: remove incorrect assert in utils_align_ptr_up_size_down()
lukaszstolarczuk
force-pushed
the
merge-v0.10.x-into-main
branch
from
2803ebd to
f160016
Compare
Done |
ldorau
approved these changes
Dec 10, 2024
vinser52
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge changes from v0.10.x into main, including latest release.