-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add AttachSelectedRowsDialog #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AttachSelectedRowsDialog #465
Conversation
* fixed: <Icon /> href reference bug by relative path * added: `Attach this/these rows to relation` button to `Edit` BrowserToolbar
By analyzing the blame information on this pull request, we identified @drew-gross, @TylerBrock and @gavrix to be potential reviewers. |
@@ -28,13 +28,10 @@ export default class AttachRowsDialog extends React.Component { | |||
return [...resourceIds, objectId]; | |||
}, []); | |||
const promise = new Parse.Promise(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can shorten this whole thing to just return this.props.onConfirm(objectIds);
I think,
Looks pretty good, just a couple comments |
@drew-gross The reason wrapping <Modal
{...modalProps}
confirmText={this.state.inProgress ? inProgressText : submitText}
onConfirm={() => {
this.setState({
errorMessage: '',
inProgress: true,
});
onSubmit().then(result => {
onClose();
clearFields();
onSuccess(result);
this.setState({inProgress: false});
}).fail(({ message, error, notice, errors = [] }) => {
this.setState({
errorMessage: errors.join(' ') || message || error || notice || 'An error occurred',
inProgress: false,
});
});
}}
... /> This is how your meaning was to make |
@beingbook updated the pull request. |
@beingbook updated the pull request. |
@drew-gross change your class |
* fixed: base URL with update dependencies * updated: `FormModal` uses ES6 Promise instead of Parse.Promise
@beingbook updated the pull request. |
@beingbook updated the pull request. |
I just fixed the issues. |
…oard into heroku_master * 'master' of https://github.com/ParsePlatform/parse-dashboard: (77 commits) Updating ISSUE_TEMPLATE to match the latest versions (parse-community#525) Added support for node 4.3 and some documentation to Authentication.js (parse-community#513) Added add row button to data browser toolbar. (parse-community#512) Made the encrypted passwords an option (parse-community#510) Allow sorting by `createdAt` ascending (parse-community#508) Version 1.0.18 (parse-community#507) E2e test (parse-community#505) Version 1.0.17 (parse-community#502) Revert "using mount path when mounted as express module" (parse-community#501) Version 1.0.16 (parse-community#498) Added the ability to accept encrypted passwords (parse-community#487) using mount path when mounted as express module (parse-community#486) fix misspelling (parse-community#497) Add AttachSelectedRowsDialog (parse-community#465) Version 1.0.15 Add/relation viewer (parse-community#452) Changed Sidebar Footer links to open in a new tab (parse-community#460) Updated paths Procfile (parse-community#461) Add allowInsecureHTTP option with Express (parse-community#457) Note that env vars only work with parse-dashboard (parse-community#458) ...
* heroku_master: (91 commits) added latest configfile Updating ISSUE_TEMPLATE to match the latest versions (parse-community#525) Added support for node 4.3 and some documentation to Authentication.js (parse-community#513) Added add row button to data browser toolbar. (parse-community#512) Made the encrypted passwords an option (parse-community#510) Allow sorting by `createdAt` ascending (parse-community#508) Version 1.0.18 (parse-community#507) E2e test (parse-community#505) Version 1.0.17 (parse-community#502) Revert "using mount path when mounted as express module" (parse-community#501) Version 1.0.16 (parse-community#498) Added the ability to accept encrypted passwords (parse-community#487) using mount path when mounted as express module (parse-community#486) fix misspelling (parse-community#497) Add AttachSelectedRowsDialog (parse-community#465) Version 1.0.15 Add/relation viewer (parse-community#452) Changed Sidebar Footer links to open in a new tab (parse-community#460) Updated paths Procfile (parse-community#461) Add allowInsecureHTTP option with Express (parse-community#457) ... # Conflicts: # Parse-Dashboard/index.js # Parse-Dashboard/parse-dashboard-config.json
Attach this/these rows to relation
button toEdit
BrowserToolbarThis works like:

Attach this/these row(s) to relation