Allow sorting by createdAt ascending
#508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to sort by the `createdAt` column, we would still apply the default sort ordering of `-createdAt`, meaning that we would specify a sort order of `createdAt,-createdAt`. When Parse-Server gets a sort order in which the same field appears more than once, it will use the last entry for the field in its sorting. This means that the sort the user has selected is overwritten by the default sort we apply. We now check to see if the sort we are applying is already on the `createdAt` field, and if so we do not apply the default ordering. Fixes parse-community#447.
|
By analyzing the blame information on this pull request, we identified @beingbook, @drew-gross and @TylerBrock to be potential reviewers. |
ghost
added
the
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Looks good to me. |
georgeloh
added a commit
to georgeloh/parse-dashboard
that referenced
this pull request
Sep 7, 2016
…oard into heroku_master * 'master' of https://github.com/ParsePlatform/parse-dashboard: (77 commits) Updating ISSUE_TEMPLATE to match the latest versions (parse-community#525) Added support for node 4.3 and some documentation to Authentication.js (parse-community#513) Added add row button to data browser toolbar. (parse-community#512) Made the encrypted passwords an option (parse-community#510) Allow sorting by `createdAt` ascending (parse-community#508) Version 1.0.18 (parse-community#507) E2e test (parse-community#505) Version 1.0.17 (parse-community#502) Revert "using mount path when mounted as express module" (parse-community#501) Version 1.0.16 (parse-community#498) Added the ability to accept encrypted passwords (parse-community#487) using mount path when mounted as express module (parse-community#486) fix misspelling (parse-community#497) Add AttachSelectedRowsDialog (parse-community#465) Version 1.0.15 Add/relation viewer (parse-community#452) Changed Sidebar Footer links to open in a new tab (parse-community#460) Updated paths Procfile (parse-community#461) Add allowInsecureHTTP option with Express (parse-community#457) Note that env vars only work with parse-dashboard (parse-community#458) ...
georgeloh
added a commit
to georgeloh/parse-dashboard
that referenced
this pull request
Sep 7, 2016
* heroku_master: (91 commits) added latest configfile Updating ISSUE_TEMPLATE to match the latest versions (parse-community#525) Added support for node 4.3 and some documentation to Authentication.js (parse-community#513) Added add row button to data browser toolbar. (parse-community#512) Made the encrypted passwords an option (parse-community#510) Allow sorting by `createdAt` ascending (parse-community#508) Version 1.0.18 (parse-community#507) E2e test (parse-community#505) Version 1.0.17 (parse-community#502) Revert "using mount path when mounted as express module" (parse-community#501) Version 1.0.16 (parse-community#498) Added the ability to accept encrypted passwords (parse-community#487) using mount path when mounted as express module (parse-community#486) fix misspelling (parse-community#497) Add AttachSelectedRowsDialog (parse-community#465) Version 1.0.15 Add/relation viewer (parse-community#452) Changed Sidebar Footer links to open in a new tab (parse-community#460) Updated paths Procfile (parse-community#461) Add allowInsecureHTTP option with Express (parse-community#457) ... # Conflicts: # Parse-Dashboard/index.js # Parse-Dashboard/parse-dashboard-config.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to sort by the
createdAtcolumn, we would still applythe default sort ordering of
-createdAt, meaning that we would specifya sort order of
createdAt,-createdAt. When Parse-Server gets a sortorder in which the same field appears more than once, it will use the
last entry for the field in its sorting. This means that the sort the
user has selected is overwritten by the default sort we apply.
We now check to see if the sort we are applying is already on the
createdAtfield, and if so we do not apply the default ordering.Fixes #447.