Made the encrypted passwords an option #510
Conversation
|
By analyzing the blame information on this pull request, we identified @flovilmart, @JeremyPlease and @Zertz to be potential reviewers. |
| @@ -230,11 +230,15 @@ You can configure your dashboard for Basic Authentication by adding usernames an | |||
| "user":"user2", | |||
| "pass":"pass" | |||
| } | |||
| ] | |||
| ], | |||
| "options": { | |||
There was a problem hiding this comment.
I don't think we need this additional nesting level.
There was a problem hiding this comment.
I was trying to leave it open for future changes. Would you suggest that I just bring the setting up, or something else?
There was a problem hiding this comment.
Exactly. The whole config file is already a dict of options, it doesn't need another dict of options within it.
ghost
added
the
|
Would you mind also adding a test for this? We've had a few annoying regressions recently due to lack of testing so I'd like to start stepping up our game in the department. |
|
Not sure why the bot pinged me, I just contributed to docs once or twice ;-) |
|
@dvanwinkle updated the pull request - view changes |
|
@dvanwinkle updated the pull request - view changes |
|
@drew-gross Moved Authentication into it's own module and added some tests. This is really my first time writing Javascript tests, so, please, be nice in your review ;-) |
|
Looks solid to me! Thanks for the tests :) |
|
Nice feature! Although, I had to add "use strict" to the top of Parse-Dashboard/Authentication.js to get this to build for me. Otherwise it was returning a server error page. |
|
@johnnydimas Most likely you are using an older version of node. Looks like the minimum in the |
|
Let'S stick with 4.3, the use strict has been added :p |
…oard into heroku_master * 'master' of https://github.com/ParsePlatform/parse-dashboard: (77 commits) Updating ISSUE_TEMPLATE to match the latest versions (parse-community#525) Added support for node 4.3 and some documentation to Authentication.js (parse-community#513) Added add row button to data browser toolbar. (parse-community#512) Made the encrypted passwords an option (parse-community#510) Allow sorting by `createdAt` ascending (parse-community#508) Version 1.0.18 (parse-community#507) E2e test (parse-community#505) Version 1.0.17 (parse-community#502) Revert "using mount path when mounted as express module" (parse-community#501) Version 1.0.16 (parse-community#498) Added the ability to accept encrypted passwords (parse-community#487) using mount path when mounted as express module (parse-community#486) fix misspelling (parse-community#497) Add AttachSelectedRowsDialog (parse-community#465) Version 1.0.15 Add/relation viewer (parse-community#452) Changed Sidebar Footer links to open in a new tab (parse-community#460) Updated paths Procfile (parse-community#461) Add allowInsecureHTTP option with Express (parse-community#457) Note that env vars only work with parse-dashboard (parse-community#458) ...
* heroku_master: (91 commits) added latest configfile Updating ISSUE_TEMPLATE to match the latest versions (parse-community#525) Added support for node 4.3 and some documentation to Authentication.js (parse-community#513) Added add row button to data browser toolbar. (parse-community#512) Made the encrypted passwords an option (parse-community#510) Allow sorting by `createdAt` ascending (parse-community#508) Version 1.0.18 (parse-community#507) E2e test (parse-community#505) Version 1.0.17 (parse-community#502) Revert "using mount path when mounted as express module" (parse-community#501) Version 1.0.16 (parse-community#498) Added the ability to accept encrypted passwords (parse-community#487) using mount path when mounted as express module (parse-community#486) fix misspelling (parse-community#497) Add AttachSelectedRowsDialog (parse-community#465) Version 1.0.15 Add/relation viewer (parse-community#452) Changed Sidebar Footer links to open in a new tab (parse-community#460) Updated paths Procfile (parse-community#461) Add allowInsecureHTTP option with Express (parse-community#457) ... # Conflicts: # Parse-Dashboard/index.js # Parse-Dashboard/parse-dashboard-config.json
Discovered that my previous encrypted password implementation allowed the user to type the hash and be authenticated. I feel like that isn't going to be expected, so, I added an options config option to enable encrypted passwords.