Function Arglist Consistency (Userland / Native) #1665
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcioAlmada
force-pushed
the
arglist_consistency
branch
2 times, most recently
from
4e9afbd to
09301ea
Compare
marcioAlmada
force-pushed
the
arglist_consistency
branch
from
6bcd1ec to
465c9b3
Compare
|
@marcioAlmada fix conflicts please :) Please push forward with this RFC, alternatively, if you consider this work abandoned, please close this PR. |
|
@krakjoe thanks for the notice, I have prospects to be working on this as an RFC soon. |
|
@marcioAlmada if you need help, in any way, let me know. 👍 |
|
@marcioAlmada Will this need a Major version? Or can we start to rework on the tests and implementation and leave this RFC already voted? |
|
@carusogabriel I think that, technically, this could be proposed at any minor version. Native functions complaining about excess of arguments is not really a "feature" when already considering the lax behavior of userland functions. Please, feel free to reopen this or move to another PR ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes exceeding arglists on native functions have the same behavior as on userland functions, no BC breaks:
Zend/tests/*zend_parse_parameters_none()on the RFC?This requires RFC.