Skip to content

Convert zend_parse_parameters_none() to fast ZPP in standard lib #5037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

These were the only occurrences of zend_parse_parameters_none() in the standard extension.

@carusogabriel
Copy link
Contributor

Please, see #3116, and #1665 :)

@nikic
Copy link
Member

nikic commented Dec 30, 2019

@carusogabriel As it's not really clear when and if at all that change is going to happen, I'm okay with doing this conversion in the meantime. However, I think if we do it, we should do it for the whole codebase, as your previous PR did.

@kocsismate
Copy link
Member Author

kocsismate commented Dec 30, 2019

@nikic Wasn't it said that we should only use fast ZPP for the most "popular" functions/methods? What changed since then? Binary size doesn't matter that much anymore? (Because of JIT?)

Anyway, I can help/continue the work that @carusogabriel did.

@carusogabriel
Copy link
Contributor

The last time that I tried to convert some ZPP calls to the new API was #3041 (comment), might help the discussion here :)

@nikic
Copy link
Member

nikic commented Dec 30, 2019

@kocsismate ZEND_PARSE_PARAMETERS_NONE() specifically doesn't have code-size concerns.

On the other hand, I'm not sure how much sense this makes style-wise.

@kocsismate
Copy link
Member Author

kocsismate commented Dec 30, 2019

@nikic Didn't know that 😮

On the other hand, I'm not sure how much sense this makes style-wise.

Then we could do the migration only for those extensions that already use fast ZPP. I think that's a good middle ground.

Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kocsismate Sounds reasonable. As ext/standard uses FastZPP fairly consistently (right...?) I guess your version here is fine.

@kocsismate
Copy link
Member Author

ext/standard uses FastZPP fairly consistently (right...?)

Yep, only 10 occurrences of zend_parse_parameters() left in ext/standard. I'll have a look at the other extensions how much they use zend_parse_parameters_none() in the coming days.

@php-pulls php-pulls closed this in e34a1f9 Dec 30, 2019
@kocsismate kocsismate deleted the standard-fast-zpp branch December 30, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants