Use ZEND_PARSE_PARAMETERS_NONE() macro #3116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Feb 19, 2018
Zend/zend_API.h
Outdated
| @@ -266,6 +266,8 @@ ZEND_API int zend_copy_parameters_array(int param_count, zval *argument_array); | |||
| #define zend_parse_parameters_none_throw() \ | |||
| (EXPECTED(ZEND_NUM_ARGS() == 0) ? SUCCESS : zend_wrong_parameters_none_exception()) | |||
|
|
|||
| #define ZEND_PARSE_PARAMS_NONE() { if(ZEND_NUM_ARGS() != 0 && zend_wrong_parameters_none_error()) return; } | |||
There was a problem hiding this comment.
There already is a ZEND_PARSE_PARAMETERS_NONE() macro which does the same thing ;)
There was a problem hiding this comment.
I do need to study more C, I thought that one was different because of the do/while struct 🤦♂️
There was a problem hiding this comment.
@carusogabriel Function-like macros with more than one statement are usually wrapped in do/while, see https://stackoverflow.com/questions/154136/why-use-apparently-meaningless-do-while-and-if-else-statements-in-macros.
carusogabriel
changed the title
|
Closing as I'll probably work in #1665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that I suggested to @dstogov in 6fadb72#commitcomment-27597259