-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-39285: Clarify example for PurePath.match #19458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't understand this PR. The point of this snippet in the documentation is to show that case-sensitivity follows platform defaults. >>> PurePosixPath('b.py').match('*.PY')
False
>>> PureWindowsPath('b.py').match('*.PY')
True |
cc @barneygale |
Sounds like a wording problem. This sentence:
Can be taken to mean that
I agree that an additional example involving |
Fixes Issue39285 Provide additional example and update wording to remove ambiguity around the match functionlatiy.
Thanks! I've updated the example and wording to incorporate the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thank you
Thanks @timlo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Fixes Issue39285 The example incorrectly returned True for match. Furthermore the example is ambiguous in its usage of PureWindowsPath. Windows is case-insensitve, however the underlying match functionality utilizes fnmatch.fnmatchcase. Automerge-Triggered-By: @pitrou (cherry picked from commit c12375a) Co-authored-by: Tim Lo <[email protected]>
GH-19597 is a backport of this pull request to the 3.8 branch. |
Fixes Issue39285 The example incorrectly returned True for match. Furthermore the example is ambiguous in its usage of PureWindowsPath. Windows is case-insensitve, however the underlying match functionality utilizes fnmatch.fnmatchcase. Automerge-Triggered-By: @pitrou (cherry picked from commit c12375a) Co-authored-by: Tim Lo <[email protected]>
GH-19598 is a backport of this pull request to the 3.7 branch. |
Fixes Issue39285 The example incorrectly returned True for match. Furthermore the example is ambiguous in its usage of PureWindowsPath. Windows is case-insensitve, however the underlying match functionality utilizes fnmatch.fnmatchcase. Automerge-Triggered-By: @pitrou (cherry picked from commit c12375a) Co-authored-by: Tim Lo <[email protected]>
Fixes Issue39285 The example incorrectly returned True for match. Furthermore the example is ambiguous in its usage of PureWindowsPath. Windows is case-insensitve, however the underlying match functionality utilizes fnmatch.fnmatchcase. Automerge-Triggered-By: @pitrou (cherry picked from commit c12375a) Co-authored-by: Tim Lo <[email protected]>
Fixes Issue39285
The example incorrectly returned True for match.
Furthermore the example is ambiguous in its usage of PureWindowsPath.
Windows is case-insensitve, however the underlying match functionality
utilizes fnmatch.fnmatchcase.
https://bugs.python.org/issue39285
https://bugs.python.org/issue39285
Automerge-Triggered-By: @pitrou