-
Notifications
You must be signed in to change notification settings - Fork 266
venv.po, unicode.po, datastructures.po complete #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ence/datamodel.po
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci pour cette review ! 🎉
Co-Authored-By: Jules Lasne (jlasne) <[email protected]>
Co-Authored-By: Jules Lasne (jlasne) <[email protected]>
Co-Authored-By: Jules Lasne (jlasne) <[email protected]>
Co-Authored-By: Jules Lasne (jlasne) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques petits points et c'est bon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci pour cette PR.
Pour tes futures contributions, n'hésite pas à faire une PR par fichier (même pour quelques lignes).
C'est plus lisible est cela permet de merger plus rapidement.
(c'est un peu ma faute, je lui ai dit trop tard de faire des PR séparées) |
Co-Authored-By: Christophe Nanteuil <[email protected]>
Co-Authored-By: Christophe Nanteuil <[email protected]>
Co-Authored-By: Christophe Nanteuil <[email protected]>
Co-Authored-By: Christophe Nanteuil <[email protected]>
Co-Authored-By: Antoine <[email protected]>
Co-Authored-By: Antoine <[email protected]>
Co-Authored-By: Antoine <[email protected]>
Co-Authored-By: Antoine <[email protected]>
@drNymbus il faut que tu résoude les conflits dans github ou alors que tu ailles dans ta cmdline sur la bonne branche, mets a jour ton upstream avec |
ping @drNymbus 🏓 |
Merci infiniment de votre patience ! Du coup je viens de régler les conflits, il me reste seulement a passer le powrap, il me dit que certains espaces doivent êtres insecables, j'ai alors rajouté ces espaces mais rien ne se passe... une idée ? |
Ce n'est pas powrap qui te dit ça, mais padpo, un outil encore en béta qui donne des indications supplémentaires. Powrap te demande seulement de réindenter expressions.po (l.333 de la sortie Travis). |
@drNymbus -> @vmelancon same same ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good à part les modifications sur les espaces insécables sur la doc originale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Encore une modification et ça sera bon.
Co-Authored-By: Antoine <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:1:
Modifications demandées corrigées.
Bon travail @drNymbus ! |
No description provided.