Use llm_config instead of args in export_llama functions #11162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced May 27, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11162
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 9a15088 with merge base c2aa614 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced May 27, 2025
Closed
Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]
Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]
jackzhxng
added a commit
that referenced
this pull request
Jun 5, 2025
Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 288486592
|
This pull request was exported from Phabricator. Differential Revision: D75484927 |
larryliu0820
reviewed
Jun 6, 2025
| @@ -89,8 +92,9 @@ def prepare_model(self): | |||
| ] | |||
| parser = build_args_parser() | |||
| args = parser.parse_args(args) | |||
| llm_config = convert_args_to_llm_config(args) | |||
There was a problem hiding this comment.
Like my comment in previous PR please do LlmConfig.from_args(args)
larryliu0820
reviewed
Jun 6, 2025
Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]
jackzhxng
added a commit
that referenced
this pull request
Jun 6, 2025
Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 288794760
|
This pull request was exported from Phabricator. Differential Revision: D75484927 |
Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]
jackzhxng
added a commit
that referenced
this pull request
Jun 6, 2025
Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 288798834
|
This pull request was exported from Phabricator. Differential Revision: D75484927 |
Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]
jackzhxng
added a commit
that referenced
this pull request
Jun 6, 2025
Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 288807822
|
This pull request was exported from Phabricator. Differential Revision: D75484927 |
larryliu0820
approved these changes
Jun 6, 2025
Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]
jackzhxng
added a commit
that referenced
this pull request
Jun 9, 2025
Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 289208261
|
This pull request was exported from Phabricator. Differential Revision: D75484927 |
Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]
jackzhxng
added a commit
that referenced
this pull request
Jun 9, 2025
Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 289227698
|
This pull request was exported from Phabricator. Differential Revision: D75484927 |
Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]
jackzhxng
added a commit
that referenced
this pull request
Jun 9, 2025
Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 289273387
|
This pull request was exported from Phabricator. Differential Revision: D75484927 |
facebook-github-bot
merged commit 27afa9c
into
gh/jackzhxng/14/base
194 of 200 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
jackzhxng
added a commit
that referenced
this pull request
Jun 10, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11162 by @jackzhxng ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/jackzhxng/14/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/jackzhxng/14/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/jackzhxng/12/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/jackzhxng/14/orig @diff-train-skip-merge --------- Co-authored-by: Jack Zhang <[email protected]>
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 287798909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D75484927