[ET-VK][EZ] Fix StorageBuffer size in PrepackNode #2811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a bug I wrote, but in my defense the bug was in the code I copied. 😛 This change decreases the size of our staging `StorageBuffer`s which were previously bigger than necessary. There's a few numbers describing size at play: ``` numel -> CPU buffer nbytes -> numel * cpu_dtype gpu_numel -> GPU texture gpu_nbytes -> gpu_numel * gpu_dtype ``` Firstly, `StorageBuffer`'s ctor takes `numel` not `nbytes`. Secondly, we should use the CPU size not the GPU size which may be aligned up to a multiple of 4. Differential Revision: [D55619076](https://our.internmc.facebook.com/intern/diff/D55619076/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2811
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3f27222 with merge base d612c23 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55619076 |
SS-JIA
approved these changes
Apr 2, 2024
|
This pull request has been merged in b1efd43. |
This was referenced Apr 3, 2024
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 4, 2024
Summary: Pull Request resolved: pytorch#2811 Fixing a bug I wrote, but in my defense the bug was in the code I copied. 😛 This change decreases the size of our staging `StorageBuffer`s which were previously bigger than necessary. There's a few numbers describing size at play: ``` numel -> CPU buffer nbytes -> numel * cpu_dtype gpu_numel -> GPU texture gpu_nbytes -> gpu_numel * gpu_dtype ``` Firstly, `StorageBuffer`'s ctor takes `numel` not `nbytes`. Secondly, we should use the CPU size not the GPU size which may be aligned up to a multiple of 4. ghstack-source-id: 220995380 exported-using-ghexport Reviewed By: copyrightly, SS-JIA Differential Revision: D55619076 fbshipit-source-id: 9a63ee6111ce9b16b1aecba051c29a662e6d12dd
This was referenced Apr 5, 2024
Closed
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Fixing a bug I wrote, but in my defense the bug was in the code I copied. 😛 This change decreases the size of our staging `StorageBuffer`s which were previously bigger than necessary. There's a few numbers describing size at play: ``` numel -> CPU buffer nbytes -> numel * cpu_dtype gpu_numel -> GPU texture gpu_nbytes -> gpu_numel * gpu_dtype ``` Firstly, `StorageBuffer`'s ctor takes `numel` not `nbytes`. Secondly, we should use the CPU size not the GPU size which may be aligned up to a multiple of 4. Differential Revision: [D55619076](https://our.internmc.facebook.com/intern/diff/D55619076/) ghstack-source-id: 220995380 Pull Request resolved: pytorch/executorch#2811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixing a bug I wrote, but in my defense the bug was in the code I copied. 😛
This change decreases the size of our staging
StorageBuffers which were previously bigger than necessary.There's a few numbers describing size at play:
Firstly,
StorageBuffer's ctor takesnumelnotnbytes. Secondly, we should use the CPU size not the GPU size which may be aligned up to a multiple of 4.Differential Revision: D55619076