[executorch] Optimized 2D-by-1D broadcasting in optimized op_mul #4808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect that we are doing an elementwise multiplication for a 2D tensor and a 1D tensor. Dispatch to a vectorized kernel for this case. Differential Revision: [D61560826](https://our.internmc.facebook.com/intern/diff/D61560826/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4808
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit fefc4a2 with merge base 35e2302 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Aug 20, 2024
swolchok
added a commit
that referenced
this pull request
Aug 20, 2024
Detect that we are doing an elementwise multiplication for a 2D tensor and a 1D tensor. Dispatch to a vectorized kernel for this case. Differential Revision: [D61560826](https://our.internmc.facebook.com/intern/diff/D61560826/) ghstack-source-id: 238994618 Pull Request resolved: #4808
|
This pull request was exported from Phabricator. Differential Revision: D61560826 |
swolchok
requested review from
kimishpatel,
GregoryComer and
manuelcandales
and removed request for
kimishpatel
…op_mul" Detect that we are doing an elementwise multiplication for a 2D tensor and a 1D tensor. Dispatch to a vectorized kernel for this case. Differential Revision: [D61560826](https://our.internmc.facebook.com/intern/diff/D61560826/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D61560826 |
swolchok
added a commit
that referenced
this pull request
Aug 20, 2024
Pull Request resolved: #4808 Detect that we are doing an elementwise multiplication for a 2D tensor and a 1D tensor. Dispatch to a vectorized kernel for this case. ghstack-source-id: 239001636 @exported-using-ghexport Differential Revision: [D61560826](https://our.internmc.facebook.com/intern/diff/D61560826/)
kimishpatel
approved these changes
Aug 26, 2024
…op_mul" Detect that we are doing an elementwise multiplication for a 2D tensor and a 1D tensor. Dispatch to a vectorized kernel for this case. Differential Revision: [D61560826](https://our.internmc.facebook.com/intern/diff/D61560826/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D61560826 |
…op_mul" Detect that we are doing an elementwise multiplication for a 2D tensor and a 1D tensor. Dispatch to a vectorized kernel for this case. Differential Revision: [D61560826](https://our.internmc.facebook.com/intern/diff/D61560826/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D61560826 |
facebook-github-bot
merged commit 0e077cf
into
gh/swolchok/18/base
36 of 38 checks passed
This was referenced Aug 29, 2024
kirklandsign
added a commit
that referenced
this pull request
Aug 29, 2024
Detect that we are doing an elementwise multiplication for a 2D tensor and a 1D tensor. Dispatch to a vectorized kernel for this case. Differential Revision: [D61560826](https://our.internmc.facebook.com/intern/diff/D61560826/) Pull Request resolved: #4808 --------- Co-authored-by: Scott Wolchok <[email protected]>
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#4808 Detect that we are doing an elementwise multiplication for a 2D tensor and a 1D tensor. Dispatch to a vectorized kernel for this case. ghstack-source-id: 240122842 @exported-using-ghexport Differential Revision: [D61560826](https://our.internmc.facebook.com/intern/diff/D61560826/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Detect that we are doing an elementwise multiplication for a 2D tensor and a 1D tensor. Dispatch to a vectorized kernel for this case.
Differential Revision: D61560826