Skip to content

Revert "Fix ARM submodule URLs (#6973)" #6987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Fix ARM submodule URLs (#6973)" #6987

wants to merge 1 commit into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Nov 20, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

The review. URLs are preferred due to lower resource usage per #6973 (comment)

Differential Revision: D66247100

@swolchok
Revert "Fix ARM submodule URLs (#6973)"
2d4e43c 
Apparently the `review.` URLs are preferred due to lower resource usage.

Differential Revision: [D66247100](https://our.internmc.facebook.com/intern/diff/D66247100/)

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2024
@swolchok swolchok mentioned this pull request Nov 20, 2024
Merged
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 20, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6987

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 36 New Failures

As of commit 2d4e43c with merge base dcacde0 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66247100

@swolchok swolchok mentioned this pull request Nov 20, 2024
Merged
@digantdesai digantdesai added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Nov 20, 2024
@digantdesai
Copy link
Contributor

cc @robell

@freddan80
Copy link
Collaborator

I think we can keep the github mirrors #6989 until we've migrated from mlplatform.

@digantdesai
Copy link
Contributor

@freddan80 - FYI #6989 adds github mirrors which is landed.

Since we are talking about migration, do you have a rough estimate, I heard someone say "next year" as a passing comment. :)

@swolchok swolchok closed this Nov 21, 2024
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@swolchok
Revert "Fix ARM submodule URLs (#6973)"
6760cbe 
Apparently the `review.` URLs are preferred due to lower resource usage.

Differential Revision: [D66247100](https://our.internmc.facebook.com/intern/diff/D66247100/)

ghstack-source-id: 254597887
Pull Request resolved: pytorch/executorch#6987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@swolchok @facebook-github-bot @digantdesai @freddan80 @zingo