Replace browser UI with Basic Streamlit UI Implementation #908
+105
−283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/908
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f24f79d with merge base b0081ed ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
dbort
reviewed
Jul 16, 2024
dbort
reviewed
Jul 16, 2024
Jack-Khuu
approved these changes
Jul 16, 2024
dbort
approved these changes
Jul 17, 2024
dbort
pushed a commit
that referenced
this pull request
Jul 17, 2024
Introduces basic Python dataclasses to represent requests, responses,
and associated objects defined in the OpenAI API specification. This
will enable creating a basic server that follows the spec so users can
leverage TorchChat to run LLMs on their own hardware with a familiar
interface to existing cloud tools.
**Testing**
Lintunner
```
lintrunner
Warning: Could not find a lintrunner config at: '.lintrunner.private.toml'. Continuing without using configuration file.
>>> Lint for generate.py:
Advice (FLAKE8) C901
'Generator.chat' is too complex (32)
See https://www.flake8rules.com/rules/C901.html.
581 | buffer.clear()
582 | # print(, end='', flush=True)
583 |
>>> 584 | def chat(
585 | self,
586 | generator_args: GeneratorArgs,
587 | ):
```
(advice from prior commit)
Dataclasses are used and tested further in PR #908
dbort
pushed a commit
that referenced
this pull request
Jul 17, 2024
Introduces basic Python dataclasses to represent requests, responses,
and associated objects defined in the OpenAI API specification. This
will enable creating a basic server that follows the spec so users can
leverage TorchChat to run LLMs on their own hardware with a familiar
interface to existing cloud tools.
**Testing**
Lintunner
```
lintrunner
Warning: Could not find a lintrunner config at: '.lintrunner.private.toml'. Continuing without using configuration file.
>>> Lint for generate.py:
Advice (FLAKE8) C901
'Generator.chat' is too complex (32)
See https://www.flake8rules.com/rules/C901.html.
581 | buffer.clear()
582 | # print(, end='', flush=True)
583 |
>>> 584 | def chat(
585 | self,
586 | generator_args: GeneratorArgs,
587 | ):
```
(advice from prior commit)
Dataclasses are used and tested further in PR #908
dbort
pushed a commit
that referenced
this pull request
Jul 17, 2024
Introduces basic Python dataclasses to represent requests, responses,
and associated objects defined in the OpenAI API specification. This
will enable creating a basic server that follows the spec so users can
leverage TorchChat to run LLMs on their own hardware with a familiar
interface to existing cloud tools.
**Testing**
Lintunner
```
lintrunner
Warning: Could not find a lintrunner config at: '.lintrunner.private.toml'. Continuing without using configuration file.
>>> Lint for generate.py:
Advice (FLAKE8) C901
'Generator.chat' is too complex (32)
See https://www.flake8rules.com/rules/C901.html.
581 | buffer.clear()
582 | # print(, end='', flush=True)
583 |
>>> 584 | def chat(
585 | self,
586 | generator_args: GeneratorArgs,
587 | ):
```
(advice from prior commit)
Dataclasses are used and tested further in PR #908
Remove the existing browser UI and replace it with a UI built with Streamlit. This reduces complexity & leverages the functionality introduced in PR #906 to display chunked responses. **Testing** ``` streamlit run torchchat.py -- browser stories110M --compile --max-new-tokens 256 You can now view your Streamlit app in your browser. Local URL: http://localhost:8501 Network URL: http://192.0.0.2:8501 ``` <img width="1002" alt="image" src="https://github.com/user-attachments/assets/df305943-2326-4d01-a48b-61dd2006fa28">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(3/3) Split #875 into separate PRs.
Remove the existing browser UI and replace it with a UI built with Streamlit. This reduces complexity & leverages the functionality introduced in PR #906 to display chunked responses.
Testing
Stack from ghstack (oldest at bottom):