Skip to content

Set up OpenAI API Python Dataclasses #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Set up OpenAI API Python Dataclasses #907

merged 1 commit into from
Jul 17, 2024

Conversation

vmpuri
Copy link
Contributor

@vmpuri vmpuri commented Jul 16, 2024

(2/3) Split #875 into separate PRs.

Introduces basic Python dataclasses to represent requests, responses, and associated objects defined in the OpenAI API specification. This will enable creating a basic server that follows the spec so users can leverage TorchChat to run LLMs on their own hardware with a familiar interface to existing cloud tools.

Testing
Lintunner

lintrunner
Warning: Could not find a lintrunner config at: '.lintrunner.private.toml'. Continuing without using configuration file.


>>> Lint for generate.py:

  Advice (FLAKE8) C901
    'Generator.chat' is too complex (32)
    See https://www.flake8rules.com/rules/C901.html.

        581  |            buffer.clear()
        582  |        # print(, end='', flush=True)
        583  |
    >>> 584  |    def chat(
        585  |        self,
        586  |        generator_args: GeneratorArgs,
        587  |    ):

(advice from prior commit)

Dataclasses are used and tested further in PR #908

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Jul 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/907

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 1e1d04d with merge base ab85b2a (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 16, 2024
@dbort dbort self-requested a review July 16, 2024 17:44
vmpuri pushed a commit that referenced this pull request Jul 17, 2024
ghstack-source-id: cc8f13a
Pull Request resolved: #907
vmpuri pushed a commit that referenced this pull request Jul 17, 2024
ghstack-source-id: cc8f13a
Pull Request resolved: #907
malfet pushed a commit that referenced this pull request Jul 17, 2024
ghstack-source-id: cc8f13a
Pull Request resolved: #907
@dbort dbort force-pushed the gh/vmpuri/2/head branch from 5247125 to 24b9327 Compare July 17, 2024 22:42
@dbort dbort changed the base branch from gh/vmpuri/2/base to main July 17, 2024 22:42
Introduces basic Python dataclasses to represent requests, responses,
and associated objects defined in the OpenAI API specification. This
will enable creating a basic server that follows the spec so users can
leverage TorchChat to run LLMs on their own hardware with a familiar
interface to existing cloud tools.

**Testing**
Lintunner
```
lintrunner
Warning: Could not find a lintrunner config at: '.lintrunner.private.toml'. Continuing without using configuration file.

>>> Lint for generate.py:

  Advice (FLAKE8) C901
    'Generator.chat' is too complex (32)
    See https://www.flake8rules.com/rules/C901.html.

        581  |            buffer.clear()
        582  |        # print(, end='', flush=True)
        583  |
    >>> 584  |    def chat(
        585  |        self,
        586  |        generator_args: GeneratorArgs,
        587  |    ):
```
(advice from prior commit)

Dataclasses are used and tested further in PR #908
@dbort dbort force-pushed the gh/vmpuri/2/head branch from 24b9327 to 1e1d04d Compare July 17, 2024 23:08
@dbort dbort merged commit b0081ed into main Jul 17, 2024
50 of 51 checks passed
@dbort dbort deleted the gh/vmpuri/2/head branch July 17, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants