Rebase master to 4-0-dev #2159
Closed
Rebase master to 4-0-dev #2159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Error: The `Layout/FirstParameterIndentation` cop has been renamed to `Layout/IndentFirstArgument`. (obsolete configuration found in .rubocop_rspec_base.yml, please update it) The `Layout/IndentArray` cop has been renamed to `Layout/IndentFirstArrayElement`. (obsolete configuration found in .rubocop_rspec_base.yml, please update it)
[skip ci]
Prevent webdrivers from using `&.` method on unsupported ruby.
Pin webdrivers on older ruby.
RVM doesn't provide old Ruby binaries for newer Ubuntu distributions. Until it's fixed, we need to use old Ubuntu distributions in CI.
Use trusty for TravisCI build
…07-08-for-master Updates from rspec-dev (2019-07-08)
…07-24-for-master Updates from rspec-dev (2019-07-24)
Rails 6.0 will require Ruby >= 2.5.0 - see rails/rails#34754.
* Add ActionMailbox spec helpers and test type Adds the following helpers to example groups with `:type => :mailbox` * process(mail_or_attributes) - send mail directly to the mailbox under test for `process`ing. * receive_inbound_email(mail_or_attributes) - matcher for asserting whether incoming email would route to the mailbox under test. * have_been_delivered - matcher for asserting whether an incoming email object was delivered. * have_bounced - matcher for asserting whether an incoming email object has bounced. * have_failed - matcher for asserting whether an incoming email object has failed. Also adds an ActionMailbox test generator * Add style changes from code review
- fix warnings for wrong namespaces - fix safe navigation offense - turn off frozen string literal cop
this provide parity with have_enqueued_job with partial arguments which would be useful especially in negated case where we want to make sure that absolutely no emails are enqueued
The previous documentation was old and was not clear enough to help
developers to understand properly how to test cookies inside a
controller test. Since then it is much easier to test cookies if you
stick to `cookies` and don't use `response.cookies`.
You can use response.cookies when you don't change cookies inside your
test.
```
def show
cookies["user_name"] = nil
head 200
end
RSpec.describe SignOutsController, type: :request do
describe 'GET /signout' do
it "clear cookie value" do
get "/sign_out"
expect(response.cookies["user_name"]).to eq(nil)
end
end
end
```
Use `cookies` to set and expect when you set cookies inside your test
```
def show
cookies.delete("user_name")
head 200
end
RSpec.describe SignOutsController, type: :request do
describe 'GET /signout' do
it "clear cookie value" do
cookies["user_name"] = "Sam"
get "/sign_out"
expect(cookies["user_name"]).to eq("")
end
end
end
```
This is the prefered way and this is way it is documented like that.
Related:
- #1993
action-cable-testing migration, pt.1
- parameterized mailer when RAILS_VERSION >= 5.1 - unified mailer job when RAILS_VERSION >= 6.0
This feature test is filtered on @rails_post_5
|
Closing in favor of #2160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I wanted to fix the conflict on 4-0-dev but I am not sure I understand the current status of the branch when I see all of those changes.
Is there something wrong with #2071 (comment)
Do we prefer to cherry pick commit @JonRowe and @samphippen ? It should be awesome to release RSpec Rails 4.