Add vrshl, vrshr, vrshrn, vrsra, vsra neon instructions #1127
+6,278
−4,073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
Amanieu
reviewed
Apr 19, 2021
| /// Signed rounding shift right and accumulate | ||
| #[inline] | ||
| #[target_feature(enable = "neon")] | ||
| #[cfg_attr(test, assert_instr(nop, N = 2))] |
There was a problem hiding this comment.
This should generate srsra. I have checked that clang generates this so we should be able to do the same.
There was a problem hiding this comment.
Thanks for pointing. But we can't seem to optimize it to srsra. In Clang, it calls llvm.aarch64.neon.srshl.i64, but the i64 suffix has bugs under some architectures (aarch64-linux-android)
There was a problem hiding this comment.
I converted i64 to int64x1_t, but then it can't be optimized to srsra
There was a problem hiding this comment.
Don't worry about it then, but put a comment explaining that it doesn't optimize properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the fowwing:
The Github comparison program is not displayed correctly. This PR did not make any changes to the original instructions