zed: yoga merge #938
Merged
zed: yoga merge #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markgoddard
commented
Feb 13, 2024
markgoddard
commented
- Update smartmon-tools.yml
- Fix permissions on reset-bls-entries playbook
- CI: Add retries to TF apply in aio job
- CI: Trim down package dependencies
- Correct OpenSearch migration instructions
- Bump docker build and push action to v5
- Bump stackhpc.kayobe_workflows to version 1.0.3
- Revert "Don't verify Apt repo CA initially when using HTTPS in container build"
- Revert "Add package repository credentials to container image build"
- Add Ansible Galaxy roles and collections to .gitignore
- Update etc/kayobe/ansible/smartmon-tools.yml
- Add a playbook to deploy an authenticating Pulp proxy
- Use authenticating Pulp proxy during container image builds
- CI: Avoid hitting Dockerhub rate limits
Fix grammar
Fix permissions on reset-bls-entries playbook
We sometimes hit temporary failures during VM creation. Adding a retry may help to keep things running. (cherry picked from commit 6329f1c)
(cherry picked from commit 8d9e620)
yoga: Backport CI fixes from Zed
Because we set ``kolla_enable_central_logging: true``,
``kolla_enable_elsticsearch`` is also set to true, as per the Kayobe
defaults:
```
kolla_enable_elasticsearch: "{{ not kolla_base_distro == 'rocky' and (kolla_enable_central_logging | bool or kolla_enable_osprofiler | bool or kolla_enable_skydive | bool or kolla_enable_monasca | bool) }}"
```
Update the instructions to disbale Elasticsearch explicitly.
We hit this error in a control host bootstrap otherwise. ``` ERROR! Failed to resolve the requested dependencies map. Could not satisfy the following requirements: * stackhpc.kayobe_workflows:1.0.2 (direct request) * stackhpc.kayobe_workflows:1.0.3 (dependency of "virtual collection Git repo") ```
…structions Correct OpenSearch migration instructions
…ner build" This reverts commit f8947a9. This approach is not secure and leaves credentials in images.
This reverts commit 05e1995. This approach is not secure and leaves credentials in images.
Bump stackhpc.kayobe_workflows to version 1.0.3
Co-authored-by: Alex-Welsh <[email protected]>
Update smartmon-tools.yml
Bump docker build and push action to v5
There is currently no practical, secure way to provide credentials for accessing Ark's authenticated package repositories from within a Kolla build. Docker provides build secrets, but these must be explicitly requested for each RUN statement, making them challenging to use in Kolla. This change adds a playbook that deploys an Nginx container that runs as a reverse proxy, injecting an HTTP basic authentication header into requests. Because this proxy bypasses Pulp's authentication, it must not be exposed to any untrusted environment. [1] https://docs.docker.com/build/building/secrets/
This change uses the authenticating Pulp proxy added in 6320be9 to provide container image builds access to Ark's authenticated package repositories without injecting the credentials into the built images or their metadata.
Running the hello-world container from Dockerhub at the beginning of workflows can cause us to hit rate limits. Switch to a simple docker ps.
CI: Avoid leaking credentials in container image builds
|
Testing container image build: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/7888780624 |
I don't know where this was removed, possibly in a bad merge.
Trying again... https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/7889078128 |
Alex-Welsh
approved these changes
Feb 13, 2024
Passed |
|
Upgrade job failed due to yoga net_ip issue, being fixed upstream |
Alex-Welsh
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.