swift/tensorflow merge (2020-06-09) #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on (#1286) PR45539: https://bugs.llvm.org/show_bug.cgi?id=45539 (Cherry-picked from 01bcc3e) Co-authored-by: Sanjay Patel <[email protected]>
…#1287) Currently combineInsertEltToShuffle turns insert_vector_elt into a vector_shuffle, even if the inserted element is a vector with a single element. In this case, it should be unlikely that the additional shuffle would be more efficient than a insert_vector_elt. Additionally, this fixes a infinite cycle in DAGCombine, where combineInsertEltToShuffle turns a insert_vector_elt into a shuffle, which gets turned back into a insert_vector_elt/extract_vector_elt by a custom AArch64 lowering (in visitVECTOR_SHUFFLE). Such insert_vector_elt and extract_vector_elt combinations can be lowered efficiently using mov on AArch64. There are 2 test changes in arm64-neon-copy.ll: we now use one or two mov instructions instead of a single zip1. The reason that we need a second mov in ins1f2 is that we have to move the result to the result register and is not really related to the DAGCombine fold I think. But in any case, on most uarchs, mov should be cheaper than zip1. On a Cortex-A75 for example, zip1 is twice as expensive as mov (https://developer.arm.com/docs/101398/latest/arm-cortex-a75-software-optimization-guide-v20) Reviewers: spatel, efriedma, dmgreen, RKSimon Reviewed By: RKSimon Differential Revision: https://reviews.llvm.org/D80710 (Cherry-picked from d20a3d3)
Extend TestSwiftDynamicSelf.py to inspect the children of self in Base & Child inits.
Use raw string literals, reflow comments, exit early where possible, and replace a bitwise-or with a logical-or operation.
This has no effect on the testsuite and was only needed in an early prototype from before debugserver was able to report the correct platform. (cherry picked from commit 2d2a603)
Remove redundant code (NFC)
This fixes an unhandled signed integer overflow in AddWithCarry() by using the llvm::checkedAdd() function. Thats to Vedant Kumar for the suggestion! <rdar://problem/60926115> Differential Revision: https://reviews.llvm.org/D80955 (cherry picked from commit a0b674f)
Fix UB in EmulateInstructionARM64.cpp
This patch adds support for Swift's UnsafeBufferPointer and UnsafeMutableBufferPointer data formatting. It introduces a summary provider and a synthetic frontend creator for these types. Signed-off-by: Med Ismail Bennani <[email protected]>
[gardening] Extend TestSwiftDynamicSelf.py, modernize WrapExpression
[lldb/formatter] Add Swift.UnsafeBufferPointer data formatter
Newer versions of clang reject this code.
[LLDB] nullptr and false are not the same
Treat N_AST symbol table entries like other debug entries and don't emit them in the linked binary. Differential revision: https://reviews.llvm.org/D81205 (cherry picked from commit fe82d3a)
These functions really don't belong into PlatformDarwin, since they actualy query state of the Host and not of the remote platform. (cherry picked from commit 3d7b926) Conflicts: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h
instead of preferring the one chosen with xcode-select. <rdar://problem/64000666> Differential Revision: https://reviews.llvm.org/D81210 (cherry picked from commit 79daa3d)
Teach GetXcodeSDK to look in the Xcode that contains LLDB
[dsymutil] Don't emit N_AST symbol entries in the Mach-O companion file
|
Tested with swiftlang/swift#32265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.