tensorflow merge (2020-06-09) #32265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These showed up after the python 2, python 3 compatibility cleanup.
Update LLVM development policy
Instead of assuming type of its sub-pattern `is` should be able to infer type from context and then propagate that to the sub-pattern via conversion. This enables support for patterns like `.foo(_ as Foo)` where `is` would have a type different from `_` which gets inferred from associated value of `foo` and converted to `Foo` that becomes a type of `_` pattern. Resolves: rdar://problem/63510989
…odule Add a demangler option to hide a current module.
And fix the name of the underlying vector.
Now that SIL files no longer interleave parsing with type-checking, the query doesn't make much sense. Inline it into its only client, `shouldBuildSyntaxTree`.
Sink the `BuildSyntaxTree` and `CollectParsedTokens` bits into `SourceFile::ParsingFlags`, with a static method to get the parsing options from the lang opts. Also add a parsing flag for enabling the interface hash, which can be used instead of calling `enableInterfaceHash`.
The `SaveAndRestore` is unnecessary as `Parser`'s constructor already sets up the interface hash, and the request covers the `FrontendStatsTracer`.
Rename `Bag` to `Tokens`, and query the SourceManager from the ASTContext instead of storing it directly.
Currently when parsing a SourceFile, the parser gets handed pointers so that it can write the interface hash and collected tokens directly into the file. It can also call `setSyntaxRoot` at the end of parsing to set the syntax tree. In preparation for the removal of `performParseOnly`, this commit formalizes these values as outputs of `ParseSourceFileRequest`, ensuring that the file gets parsed when the interface hash, collected tokens, or syntax tree is queried.
This is temporarily swapped in as the token receiver while backtracking, so make sure we don't try to call `finalize` on it.
[Diagnostics] Refactor diagnostics related to raw representable types
* Add a benchmark for mirrors and typename->string conversion
…trix-idx Add new enum value clang::BuiltinType::IncompleteMatrixIdx to switch statements
[SourceKit] Disable complete_build_session.swift test file while investigating
test: repair the test after accidental merge without testing
…99884045bc2605 [semantic-arc-opts] Perform a rename/add some comments after talking with @atrick.
…mic-replacement
…win only product. We have a few of these like foundation, libdispatch, icu, xctest that are built outside of build-script on Darwin.
This is just based off of the defaults that we use on the buildbots as of this commit. In order to not break the bots as they are, I left the internal representation as a semicolon list of components. So this should be NFC from the perspective of the bots since they all explicitly specify llvm-install-components if needed (and we do not install without install-llvm anymore).
…ult-crash-fix [Property wrappers] Reject opaque result types when there is no initializer
I only didn't touch playground-support since I don't know if there are deps there or not. Everything else here though shouldn't need lldb to be built.
test: mark test as executable_test
…8c2b1c7e1583ca [build-script] Add support for specifying that a product is a non-darwin only product.
…9a24d036c56706 [build-script] Define default llvm_install_components.
stdlib, SIL optimizer: use the SIL copy-on-write representation in the Array types.
…4482b004aacc8f [build-script] Remove a bunch of conservative dependencies on lldb.
Removes redundant buffer zeroing in lowercased() and uppercased() by using `init(unsafeUninitializedCapacity:initializingWith:)
…-fix [Runtime] Clean up verifyMangledNameRoundtrip comment.
|
Please test with following PRs: @swift-ci please clean test tensorflow |
drodriguez
added a commit
to drodriguez/swift
that referenced
this pull request
Aug 10, 2020
This is a change that will be necessary for master-next. readobj seems to report elf32-littlearm when compiling for Android ARMv7. This is similar to commit f7cf5bd which is still available in master-next, but I think was (mistakenly) reverted with swiftlang#32265.
drodriguez
added a commit
to drodriguez/swift
that referenced
this pull request
Aug 16, 2020
This is a change that will be necessary for master-next. readobj seems to report elf32-littlearm when compiling for Android ARMv7. This is similar to commit f7cf5bd which is still available in master-next, but I think was (mistakenly) reverted with swiftlang#32265. (cherry picked from commit 80135c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.